You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by Brock Noland <br...@cloudera.com> on 2012/07/01 19:37:09 UTC
Driver.runTest wrapps IOException in a RuntimeException
Hi,
The fact that Driver.runTest wrapps IOException in a RuntimeException
is a bit annoying. It's not adding any value. I'd like to change
runTest to just throw IOE. This is a breaking change, but it's quite
obvious since well written code which calls this method will fail to
compile.
Thoughts?
Brock
--
Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
Re: Driver.runTest wrapps IOException in a RuntimeException
Posted by Brock Noland <br...@cloudera.com>.
Thanks guys, I created
https://issues.apache.org/jira/browse/MRUNIT-123 for this. Will wait
to hear if anyone else has an opinion.
On Sun, Jul 1, 2012 at 8:07 PM, Dave Beech <db...@apache.org> wrote:
> +1 from me also
>
> On 1 July 2012 20:00, Jarek Jarcec Cecho <ja...@apache.org> wrote:
>
>> I generally do not like incompatible changes, but I do agree on this one.
>> Exception wrapping in test framework seems odd to me.
>>
>> Formally speaking:
>> +1 to throw IOException
>>
>> Jarcec
>>
>> On Jul 1, 2012, at 7:37 PM, Brock Noland wrote:
>>
>> > Hi,
>> >
>> > The fact that Driver.runTest wrapps IOException in a RuntimeException
>> > is a bit annoying. It's not adding any value. I'd like to change
>> > runTest to just throw IOE. This is a breaking change, but it's quite
>> > obvious since well written code which calls this method will fail to
>> > compile.
>> >
>> > Thoughts?
>> >
>> > Brock
>> >
>> > --
>> > Apache MRUnit - Unit testing MapReduce -
>> http://incubator.apache.org/mrunit/
>>
>>
--
Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
Re: Driver.runTest wrapps IOException in a RuntimeException
Posted by Dave Beech <db...@apache.org>.
+1 from me also
On 1 July 2012 20:00, Jarek Jarcec Cecho <ja...@apache.org> wrote:
> I generally do not like incompatible changes, but I do agree on this one.
> Exception wrapping in test framework seems odd to me.
>
> Formally speaking:
> +1 to throw IOException
>
> Jarcec
>
> On Jul 1, 2012, at 7:37 PM, Brock Noland wrote:
>
> > Hi,
> >
> > The fact that Driver.runTest wrapps IOException in a RuntimeException
> > is a bit annoying. It's not adding any value. I'd like to change
> > runTest to just throw IOE. This is a breaking change, but it's quite
> > obvious since well written code which calls this method will fail to
> > compile.
> >
> > Thoughts?
> >
> > Brock
> >
> > --
> > Apache MRUnit - Unit testing MapReduce -
> http://incubator.apache.org/mrunit/
>
>
Re: Driver.runTest wrapps IOException in a RuntimeException
Posted by Jarek Jarcec Cecho <ja...@apache.org>.
I generally do not like incompatible changes, but I do agree on this one. Exception wrapping in test framework seems odd to me.
Formally speaking:
+1 to throw IOException
Jarcec
On Jul 1, 2012, at 7:37 PM, Brock Noland wrote:
> Hi,
>
> The fact that Driver.runTest wrapps IOException in a RuntimeException
> is a bit annoying. It's not adding any value. I'd like to change
> runTest to just throw IOE. This is a breaking change, but it's quite
> obvious since well written code which calls this method will fail to
> compile.
>
> Thoughts?
>
> Brock
>
> --
> Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/