You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/01/26 08:46:34 UTC

[PR] [SPARK-55196][K8S][TESTS] Add `commandTestTag` to K8s Integration Test [spark]

dongjoon-hyun opened a new pull request, #53975:
URL: https://github.com/apache/spark/pull/53975

   ### What changes were proposed in this pull request?
   
   This PR aims to add a new test tag, `commandTestTag`, to K8s Integration Test.
   
   ### Why are the changes needed?
   
   `o.a.s.deploy.k8s.integrationtest.Utils.executeCommand` requires a live pod access like `cat`, `env`, `ls`, and `df` commands . We had better distinguish this kind of test group.
   
   ```
   $ cd resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/
   
   $ git grep executeCommand
   PVTestsSuite.scala:      val contents = Utils.executeCommand("cat", s"$CONTAINER_MOUNT_PATH/$file")
   SecretsTestsSuite.scala:      val env = Utils.executeCommand("env")
   SecretsTestsSuite.scala:    val files = Utils.executeCommand("ls", s"$SECRET_MOUNT_PATH")
   SecretsTestsSuite.scala:      .executeCommand("cat", s"$SECRET_MOUNT_PATH/$ENV_SECRET_KEY_1")
   SecretsTestsSuite.scala:      .executeCommand("cat", s"$SECRET_MOUNT_PATH/$ENV_SECRET_KEY_2")
   Utils.scala:  def executeCommand(cmd: String*)(
   VolumeSuite.scala:      assert(Utils.executeCommand("df", path).contains(expected))
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, this is a test-only change.
   
   ### How was this patch tested?
   
   Pass the CIs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55196][K8S][TESTS] Add `commandTestTag` to K8s Integration Test [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #53975:
URL: https://github.com/apache/spark/pull/53975#issuecomment-3798748706

   Could you review this PR, @LuciferYang ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55196][K8S][TESTS] Add `commandTestTag` to K8s Integration Test [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53975:
URL: https://github.com/apache/spark/pull/53975#issuecomment-3798474129

   ## JIRA Issue Information
   
   === Sub-task SPARK-55196 ===
   Summary: Add `commandTestTag` to K8s Integration Test
   Assignee: None
   Status: Open
   Affected: ["4.2.0"]
   
   ---
   *This comment was automatically generated by GitHub Actions*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55196][K8S][TESTS] Add `commandTestTag` to K8s Integration Test [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #53975:
URL: https://github.com/apache/spark/pull/53975#issuecomment-3799023392

   Thank you so much, @LuciferYang . Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-55196][K8S][TESTS] Add `commandTestTag` to K8s Integration Test [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #53975: [SPARK-55196][K8S][TESTS] Add `commandTestTag` to K8s Integration Test
URL: https://github.com/apache/spark/pull/53975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org