You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/12/10 03:07:12 UTC
[kudu-CR] env: rename writable file use fsync to env file use fsync
Hello Dan Burkert, Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5458
to review the following change.
Change subject: env: rename writable_file_use_fsync to env_file_use_fsync
......................................................................
env: rename writable_file_use_fsync to env_file_use_fsync
It's not just used for writable_file. And I doubt anyone has set this thing;
we copied it from rocksdb to work around buggy ext3 implementations.
Still, it's a backwards incompatible change, so maybe I should leave it be?
Change-Id: I66f9b448869885e855558dfc9194aabd17a8644d
---
M src/kudu/util/env_posix.cc
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/5458/1
--
To view, visit http://gerrit.cloudera.org:8080/5458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66f9b448869885e855558dfc9194aabd17a8644d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] env: rename writable file use fsync to env file use fsync
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: env: rename writable_file_use_fsync to env_file_use_fsync
......................................................................
env: rename writable_file_use_fsync to env_file_use_fsync
It's not just used for writable_file. And I doubt anyone has set this thing;
we copied it from rocksdb to work around buggy ext3 implementations.
Still, it's a backwards incompatible change, so maybe I should leave it be?
Change-Id: I66f9b448869885e855558dfc9194aabd17a8644d
Reviewed-on: http://gerrit.cloudera.org:8080/5458
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/util/env_posix.cc
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66f9b448869885e855558dfc9194aabd17a8644d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] env: rename writable file use fsync to env file use fsync
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: env: rename writable_file_use_fsync to env_file_use_fsync
......................................................................
Patch Set 1: Code-Review+2
Sounds reasonable, OK I retract my -1
--
To view, visit http://gerrit.cloudera.org:8080/5458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66f9b448869885e855558dfc9194aabd17a8644d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] env: rename writable file use fsync to env file use fsync
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: env: rename writable_file_use_fsync to env_file_use_fsync
......................................................................
Patch Set 1:
Given that the flag wasn't marked 'stable', the default is 'evolving' and thus we're allowed to change it between releases with a suitable release note. Given that I forgot the flag even existed, and it was never marked stable, I think it's fine to change.
--
To view, visit http://gerrit.cloudera.org:8080/5458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66f9b448869885e855558dfc9194aabd17a8644d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] env: rename writable file use fsync to env file use fsync
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: env: rename writable_file_use_fsync to env_file_use_fsync
......................................................................
Patch Set 1: Code-Review-1
In my opinion you just missed the boat for stuff like this. If you want to do this, I think you should make it backwards compatible with an alias. Unfortunately gflags doesn't support aliases yet so it needs to be a "manual" alias (see https://github.com/gflags/gflags/issues/76 )
--
To view, visit http://gerrit.cloudera.org:8080/5458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66f9b448869885e855558dfc9194aabd17a8644d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No