You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by junichi11 <gi...@git.apache.org> on 2017/10/03 11:07:09 UTC
[GitHub] incubator-netbeans pull request #47: [NETBEANS-54] Module Review c.jcraft.js...
GitHub user junichi11 opened a pull request:
https://github.com/apache/incubator-netbeans/pull/47
[NETBEANS-54] Module Review c.jcraft.jsch
- external library jsch-0.1.54.jar: BSD-jsch-variant. Maven coordinates added.
- checked Rat report: everything has been relicensed to Apache, included in 'central problems' list above, or excluded via Rat
- skimmed through the module, did not notice additional problems
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/junichi11/incubator-netbeans module-review-c.jcraft.jsch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit 2b8ce27c354e86ecec967b9d368b5f49b9d97d5f
Author: Junichi Yamamoto <ju...@apache.org>
Date: 2017-10-03T09:40:47Z
[NETBEANS-54] Module Review c.jcraft.jsch
- external library jsch-0.1.54.jar: BSD-jsch-variant. Maven coordinates added.
- checked Rat report: everything has been relicensed to Apache, included in 'central problems' list above, or excluded via Rat
- skimmed through the module, did not notice additional problems
----
---
[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/47
These look good to me.
Before doing the final push you might do:
---
[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch
Posted by junichi11 <gi...@git.apache.org>.
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/47
@jlahoda I'm sorry... Would you please do that?
---
[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch
Posted by junichi11 <gi...@git.apache.org>.
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/47
@emilianbold Yes. Are the following steps OK if I push my changes myself?
```
$ cd incubator-netbeans
$ git remote add upstream-apache https://git-wip-us.apache.org/repos/asf/incubator-netbeans
$ git checkout master
$ git pull upstream-apache master
$ git push origin master
$ git checkout module-review-branch
$ git rebase master module-review-branch
$ git push -f origin module-review-branch
$ git checkout master
$ git merge module-review-branch
$ git push upstream-apache master
```
---
[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/47
Please note that this changes fail the build, because the jar from maven central has a different hash. The hash on the central is:
DA3584329A263616E277E15462B387ADDD1B208D
I skimmed through the differences, and so far it seems to me it is OK to use the jar from central (we presumably would eventually learn if there would be issues anyway). I can do that tonight, unless someone will do that before.
---
[GitHub] incubator-netbeans pull request #47: [NETBEANS-54] Module Review c.jcraft.js...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/47
---
[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/47
You know, I was just thinking how super useful it is to have the hash when switching to Maven Central since at least you know it's the same JAR.
How could they differ for the same library?
---
[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/47
Looks good.
---
[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch
Posted by junichi11 <gi...@git.apache.org>.
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/47
Thank you for it :) I'll push changes tomorrow.
---
[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/47
I agree the hash is useful (among other things) to verify that the jar from the central is the same.
But it is unfortunately not the same in this case. Seems the jar on hg/binaries is the same as a download from the JSch web page, and the jar on maven central is different. My wild guess is that these have been produced by different build processes and different JDKs.
---
[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/47
@junichi11 will you commit this yourself?
---