[GitHub] [spark] HyukjinKwon commented on a change in pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #29890:
URL: https://github.com/apache/spark/pull/29890#discussion_r528440617



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/expressions/expressions.scala
##########
@@ -115,11 +115,10 @@ private[sql] final case class BucketTransform(
 }
 
 private[sql] object BucketTransform {

Review comment:
       Looks like you should update DataFrameWriter.scala, functions.scala, functions.py, etc related codes. cc @rdblue, @brkyvz and @zero323 FYI




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org