You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/10/29 09:11:54 UTC

[GitHub] [submarine] pingsutw commented on a change in pull request #781: SUBMARINE-1045. Add static type parameter in submarine-sdk

pingsutw commented on a change in pull request #781:
URL: https://github.com/apache/submarine/pull/781#discussion_r734213295



##########
File path: submarine-sdk/pysubmarine/submarine/models/client.py
##########
@@ -37,10 +37,10 @@
 class ModelsClient:
     def __init__(
         self,
-        tracking_uri=None,
-        registry_uri=None,
-        aws_access_key_id=None,
-        aws_secret_access_key=None,
+        tracking_uri: str = None,
+        registry_uri: str = None,
+        aws_access_key_id: str = None,
+        aws_secret_access_key: str = None,

Review comment:
       we should use typing.Optional[str] when default value is None




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org