[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8224: [sqllab] create query slightly earlier

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8224: [sqllab] create query slightly earlier
URL: https://github.com/apache/incubator-superset/pull/8224#discussion_r324400138
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -2613,6 +2606,15 @@ def sql_json(self):
             raise Exception(_("Query record was not created as expected."))
         logging.info("Triggering query_id: {}".format(query_id))
 
+        rejected_tables = security_manager.rejected_tables(sql, mydb, schema)
+        if rejected_tables:
+            return json_error_response(
 
 Review comment:
   We should probably set the query status to `FAILED` here with an error message, do a `session.commit()` then return the error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org