[jira] [Commented] (GOSSIP-100) README.md is out of date

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GOSSIP-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272036#comment-16272036 ] 

ASF GitHub Bot commented on GOSSIP-100:
---------------------------------------

Github user jeffbarg commented on a diff in the pull request:

    https://github.com/apache/incubator-gossip/pull/70#discussion_r153970186
  
    --- Diff: README.md ---
    @@ -16,22 +16,29 @@ To gossip you need one or more seed nodes. Seed is just a list of places to init
     ```java
       GossipSettings settings = new GossipSettings();
       int seedNodes = 3;
    -  List<GossipMember> startupMembers = new ArrayList<>();
    +  List<Member> startupMembers = new ArrayList<>();
       for (int i = 1; i < seedNodes+1; ++i) {
         URI uri = new URI("udp://" + "127.0.0.1" + ":" + (50000 + i));
    -    startupMembers.add(new RemoteGossipMember(cluster, uri, i + ""));
    +    startupMembers.add(new RemoteMember(cluster, uri, i + ""));
    --- End diff --
    
    It actually may not be immediately obvious (it was not for me!) that cluster here is a String ID for the cluster.  Perhaps explicitly add this so that this code block is stand-alone runnable?


> README.md is out of date
> ------------------------
>
>                 Key: GOSSIP-100
>                 URL: https://issues.apache.org/jira/browse/GOSSIP-100
>             Project: Gossip
>          Issue Type: Improvement
>            Reporter: Hongze Zhang
>
> Unable to run a quick start by following README.md, example code is out of date.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)