[jira] [Comment Edited] (CASSANDRA-11402) Alignment wrong in tpstats output for PerDiskMemtableFlushWriter and format to YAML is broken

["Stefan Miklosovic (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-11402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189607#comment-17189607 ] 

Stefan Miklosovic edited comment on CASSANDRA-11402 at 9/2/20, 6:09 PM:
------------------------------------------------------------------------

[~brandon.williams] I realized that I can not test that. I wanted to use distributed test where I just start a node and call nodetool against that but we are not registering any thread pools there. InternalNodeProbe#getThreadPools() overrides NodeProbe#getThreadPools() with UnsupportedOperationException().

InternalNodeProbe has this in its connect method:


{code:java}
    protected void connect()
    {
        // note that we are not connecting via JMX for testing
        mbeanServerConn = null;
       ...
    }
{code}

Would you mind to go over this manually? It is just too much of a work to spend on something so trivial like this changing a lot of things, not even sure if it is possible.


was (Author: stefan.miklosovic):
[~brandon.williams] I realized that I can not test that. I wanted to use distributed test where I just start a node and call nodetool against that but we are not registering any thread pools there. InternalNodeProbe#getThreadPools() overrides NodeProbe#getThreadPools() with UnsupportedOperationException().

InternalNodeProbe has this in its connect method:


{code:java}
    protected void connect()
    {
        // note that we are not connecting via JMX for testing
        mbeanServerConn = null;
       ...
    }
{code}


> Alignment wrong in tpstats output for PerDiskMemtableFlushWriter and format to YAML is broken
> ---------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11402
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11402
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Joel Knighton
>            Assignee: Stefan Miklosovic
>            Priority: Low
>              Labels: lhf
>             Fix For: 4.0-beta
>
>         Attachments: 11402-3_5_patch1.patch, 11402-trunk.txt
>
>
> With the accompanying designation of which memtableflushwriter it is, this threadpool name is too long for the hardcoded padding in tpstats output.
> We should dynamically calculate padding so that we don't need to check this every time we add a threadpool.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org