You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/21 00:50:10 UTC

[GitHub] [hbase] ndimiduk opened a new pull request #1191: HBASE-23874 Move Jira-attached file precommit definition from script in Jenkins config to dev-support

ndimiduk opened a new pull request #1191: HBASE-23874 Move Jira-attached file precommit definition from script in Jenkins config to dev-support
URL: https://github.com/apache/hbase/pull/1191
 
 
   Two commits which I will squash after review
   1. copy-paste the existing script from the [Jenkins job configuration](https://builds.apache.org/view/H-L/view/HBase/job/PreCommit-HBASE-Build/configure)
   1. address the shellcheck complaints
   
   Step 3 will be to clean it up to match more closely the GitHub version. Would be great if they could be merged into one script, or at least two scripts with a common library of functions for building the Yetus invocation params list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] ndimiduk merged pull request #1191: HBASE-23874 Move Jira-attached file precommit definition from script in Jenkins config to dev-support

Posted by GitBox <gi...@apache.org>.
ndimiduk merged pull request #1191: HBASE-23874 Move Jira-attached file precommit definition from script in Jenkins config to dev-support
URL: https://github.com/apache/hbase/pull/1191
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1191: HBASE-23874 Move Jira-attached file precommit definition from script in Jenkins config to dev-support

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1191: HBASE-23874 Move Jira-attached file precommit definition from script in Jenkins config to dev-support
URL: https://github.com/apache/hbase/pull/1191#issuecomment-589448242
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 41s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 37s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  0s |  ASF License check generated no output?  |
   |  |   |   2m 19s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1191/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1191 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux 67bec13fc7e9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1191/out/precommit/personality/provided.sh |
   | git revision | master / fe0d49bc52 |
   | Max. process+thread count | 50 (vs. ulimit of 10000) |
   | modules | C:  U:  |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1191/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services