[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5059: vr: remove old ips with same mac address in dhcpentry databag

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #5059:
URL: https://github.com/apache/cloudstack/pull/5059#discussion_r642931321



##########
File path: systemvm/debian/opt/cloud/bin/cs_dhcp.py
##########
@@ -28,7 +28,7 @@ def merge(dbag, data):
     else:
         remove_keys = set()
         for key, entry in dbag.iteritems():
-            if key != 'id' and entry['mac_address'] == data['mac_address'] and data['remove']:
+            if key != 'id' and entry['mac_address'] == data['mac_address']:

Review comment:
       @rhtyd thanks for remarks.
   I have tested some user actions (except secondary ips), all looks good until now.
   I will test more actions manually.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org