You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/09/22 10:32:11 UTC

[GitHub] [incubator-mxnet] iblis17 commented on a change in pull request #16234: [MXNET-1426] Fix the wrong result of sum, mean, argmin, argmax when inputs contain inf or nan

iblis17 commented on a change in pull request #16234: [MXNET-1426] Fix the wrong result of sum, mean, argmin, argmax when inputs contain inf or nan
URL: https://github.com/apache/incubator-mxnet/pull/16234#discussion_r326893626
 
 

 ##########
 File path: julia/test/unittest/ndarray.jl
 ##########
 @@ -1525,8 +1525,8 @@ function test_argmax()
          NaN 2 6]
     x = NDArray(A)
 
-    @test copy(argmax(x, dims = 1)) == [1 1 2]
-    @test copy(argmax(x, dims = 2)) == reshape([2, 3], :, 1)
+    @test copy(argmax(x, dims = 1)) == [2 1 2]
 
 Review comment:
   Please consider update the docstring of `argmax`/`argmin` in `julia/src/ndarray/reduction.jl` as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services