You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2025/04/08 21:22:18 UTC
[PR] Improve simple login screen ui [airflow]
bbovenzi opened a new pull request, #48977:
URL: https://github.com/apache/airflow/pull/48977
Improve the simple auth manager login screen UI:
- Move info banner under the form so a user can quickly tab to the Username input
- Make favicon work
- Add Airflow icon and "Airflow" text to make it more obvious what you're logging into
- Update container border radius and color
<img width="783" alt="Screenshot 2025-04-08 at 5 17 31 PM" src="https://github.com/user-attachments/assets/ffc8d8bb-36c7-4e3e-b834-08022ac1528b" />
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve simple login screen ui [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #48977:
URL: https://github.com/apache/airflow/pull/48977#discussion_r2035503954
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/index.html:
##########
@@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8" />
<base href="{{ backend_server_base_url }}" />
- <link rel="icon" type="image/png" href="/pin_32.png" />
+ <link rel="icon" type="image/png" href="/sphinx_design/static/pin_32.png" />
Review Comment:
Removed from login and the main ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve simple login screen ui [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #48977:
URL: https://github.com/apache/airflow/pull/48977#discussion_r2034965387
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/index.html:
##########
@@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8" />
<base href="{{ backend_server_base_url }}" />
- <link rel="icon" type="image/png" href="/pin_32.png" />
+ <link rel="icon" type="image/png" href="/sphinx_design/static/pin_32.png" />
Review Comment:
I don't know where this `sphinx_design` is coming from, I'b love to get some more context too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve simple login screen ui [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #48977:
URL: https://github.com/apache/airflow/pull/48977#discussion_r2035404979
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/index.html:
##########
@@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8" />
<base href="{{ backend_server_base_url }}" />
- <link rel="icon" type="image/png" href="/pin_32.png" />
+ <link rel="icon" type="image/png" href="/sphinx_design/static/pin_32.png" />
Review Comment:
That doesn't look right -- `sphinx_design` is only for docs / doc-site
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve simple login screen ui [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #48977:
URL: https://github.com/apache/airflow/pull/48977#discussion_r2034965387
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/index.html:
##########
@@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8" />
<base href="{{ backend_server_base_url }}" />
- <link rel="icon" type="image/png" href="/pin_32.png" />
+ <link rel="icon" type="image/png" href="/sphinx_design/static/pin_32.png" />
Review Comment:
I don't know where this `sphinx_design` is coming from, I'b love to get some more context too.
edit: Ok I saw the related PR on tooling. Not sure why the web application should be fetching any static file from the `sphinx_design`. Those look like two distinct things.
`http://localhost:28080/static/pin_32.png` seems to work too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve simple login screen ui [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #48977:
URL: https://github.com/apache/airflow/pull/48977#discussion_r2034341350
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/index.html:
##########
@@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8" />
<base href="{{ backend_server_base_url }}" />
- <link rel="icon" type="image/png" href="/pin_32.png" />
+ <link rel="icon" type="image/png" href="/sphinx_design/static/pin_32.png" />
Review Comment:
@potiuk I was just copying your code change. Does this look right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve simple login screen ui [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #48977:
URL: https://github.com/apache/airflow/pull/48977#discussion_r2034061838
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/index.html:
##########
@@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8" />
<base href="{{ backend_server_base_url }}" />
- <link rel="icon" type="image/png" href="/pin_32.png" />
+ <link rel="icon" type="image/png" href="/sphinx_design/static/pin_32.png" />
Review Comment:
Is this the right path when I see icons added below? Are the icons not already loadable from the other deployment parts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve simple login screen ui [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #48977:
URL: https://github.com/apache/airflow/pull/48977#discussion_r2034965387
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/index.html:
##########
@@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8" />
<base href="{{ backend_server_base_url }}" />
- <link rel="icon" type="image/png" href="/pin_32.png" />
+ <link rel="icon" type="image/png" href="/sphinx_design/static/pin_32.png" />
Review Comment:
I don't know where this `sphinx_design` is coming from, I'b love to get some more context too.
edit: Ok I saw the related PR on tooling. Not sure why the web application should be fetching any static file from the `sphinx_design`. Those look like two distinct things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve simple login screen ui [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #48977:
URL: https://github.com/apache/airflow/pull/48977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve simple login screen ui [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #48977:
URL: https://github.com/apache/airflow/pull/48977#discussion_r2035404979
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/index.html:
##########
@@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8" />
<base href="{{ backend_server_base_url }}" />
- <link rel="icon" type="image/png" href="/pin_32.png" />
+ <link rel="icon" type="image/png" href="/sphinx_design/static/pin_32.png" />
Review Comment:
That doesn't look right -- `sphinx_design` is only for docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org