You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/11/03 03:48:11 UTC

[GitHub] [ratis] bzheng888 opened a new pull request, #773: Small fix

bzheng888 opened a new pull request, #773:
URL: https://github.com/apache/ratis/pull/773

   ## What changes were proposed in this pull request?
    Fix an spelling mistake
   
   ## What is the link to the Apache JIRA
   
   (Please create an issue in ASF JIRA before opening a pull request,
   and you need to set the title of the pull request which starts with
   the corresponding JIRA issue number. (e.g. RATIS-XXXX. Fix a typo in YYY.)
   
   Please replace this section with the link to the Apache JIRA)
   
   ## How was this patch tested?
   
   (Please explain how this patch was tested. Ex: unit tests, manual tests)
   (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] bzheng888 commented on pull request #773: Small fix

Posted by GitBox <gi...@apache.org>.
bzheng888 commented on PR #773:
URL: https://github.com/apache/ratis/pull/773#issuecomment-1301609366

   @codings-dan Please take a look, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] bzheng888 commented on a diff in pull request #773: RATIS-1735. Fix an spelling mistake in annotation

Posted by GitBox <gi...@apache.org>.
bzheng888 commented on code in PR #773:
URL: https://github.com/apache/ratis/pull/773#discussion_r1013584005


##########
ratis-common/src/main/java/org/apache/ratis/util/LifeCycle.java:
##########
@@ -223,7 +223,7 @@ public State transitionAndGet(UnaryOperator<State> operator) {
    * If the current state is equal to the specified from state,
    * then transition to the give to state; otherwise, make no change.
    *
-   * @return true iff the current state is equal to the specified from state.
+   * @return true if the current state is equal to the specified from state.

Review Comment:
   Amazing,  I didn't know this usage before



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] codings-dan commented on a diff in pull request #773: RATIS-1735. Fix an spelling mistake in annotation

Posted by GitBox <gi...@apache.org>.
codings-dan commented on code in PR #773:
URL: https://github.com/apache/ratis/pull/773#discussion_r1013611395


##########
ratis-common/src/main/java/org/apache/ratis/util/LifeCycle.java:
##########
@@ -223,7 +223,7 @@ public State transitionAndGet(UnaryOperator<State> operator) {
    * If the current state is equal to the specified from state,
    * then transition to the give to state; otherwise, make no change.
    *
-   * @return true iff the current state is equal to the specified from state.
+   * @return true if the current state is equal to the specified from state.

Review Comment:
   > This is not a typo iff means "if and only if";
   
   Thanks for the info, I also not hear of this usage



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] bzheng888 closed pull request #773: RATIS-1735. Fix an spelling mistake in annotation

Posted by GitBox <gi...@apache.org>.
bzheng888 closed pull request #773: RATIS-1735. Fix an spelling mistake in annotation
URL: https://github.com/apache/ratis/pull/773


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo commented on a diff in pull request #773: RATIS-1735. Fix an spelling mistake in annotation

Posted by GitBox <gi...@apache.org>.
szetszwo commented on code in PR #773:
URL: https://github.com/apache/ratis/pull/773#discussion_r1013573620


##########
ratis-common/src/main/java/org/apache/ratis/util/LifeCycle.java:
##########
@@ -223,7 +223,7 @@ public State transitionAndGet(UnaryOperator<State> operator) {
    * If the current state is equal to the specified from state,
    * then transition to the give to state; otherwise, make no change.
    *
-   * @return true iff the current state is equal to the specified from state.
+   * @return true if the current state is equal to the specified from state.

Review Comment:
   Thanks for checking the javadoc!
   
   This is not a typo iff means "if and only if"; see https://www.merriam-webster.com/dictionary/iff
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org