You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2009/06/30 20:16:47 UTC
[jira] Created: (TAP5-760) The Form event "validateForm" is
awkward, a new name (perhaps "formValidate") would be nice
The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice
-------------------------------------------------------------------------------------------
Key: TAP5-760
URL: https://issues.apache.org/jira/browse/TAP5-760
Project: Tapestry 5
Issue Type: Improvement
Components: tapestry-core
Affects Versions: 5.1.0.5
Reporter: Howard M. Lewis Ship
Priority: Minor
You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
onFormValidateFromLogin() is a bit better.
Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-760) The Form event "validateForm" is
awkwardly named and should be replaced with the simpler name "validate"
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-760.
-------------------------------------
Resolution: Fixed
Fix Version/s: 5.2.0
> The Form event "validateForm" is awkwardly named and should be replaced with the simpler name "validate"
> --------------------------------------------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-760) The Form event "validateForm" is
awkwardly named and should be replaced with the simpler name "validate"
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-760:
--------------------------------------
Summary: The Form event "validateForm" is awkwardly named and should be replaced with the simpler name "validate" (was: The Form event "validateForm" is awkward, just "validate" should do)
> The Form event "validateForm" is awkwardly named and should be replaced with the simpler name "validate"
> --------------------------------------------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-760) The Form event "validateForm" is
awkwardly named and should be replaced with the simpler name "validate"
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-760.
-------------------------------------
Resolution: Fixed
Fix Version/s: 5.2.0
> The Form event "validateForm" is awkwardly named and should be replaced with the simpler name "validate"
> --------------------------------------------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-760) The Form event "validateForm" is
awkward, just "validate" should do
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799520#action_12799520 ]
Howard M. Lewis Ship commented on TAP5-760:
-------------------------------------------
I agree ... individual form element components will fire validate events, and now the Form will as well (validateForm is being kept for compatibility). These are events you would always qualify with the component id, so there never really was a reason for validateForm in the first place.
> The Form event "validateForm" is awkward, just "validate" should do
> -------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-760) The Form event "validateForm" is
awkward, just "validate" should do
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799520#action_12799520 ]
Howard M. Lewis Ship commented on TAP5-760:
-------------------------------------------
I agree ... individual form element components will fire validate events, and now the Form will as well (validateForm is being kept for compatibility). These are events you would always qualify with the component id, so there never really was a reason for validateForm in the first place.
> The Form event "validateForm" is awkward, just "validate" should do
> -------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-760) The Form event "validateForm" is
awkward, a new name (perhaps "formValidate") would be nice
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-760:
-----------------------------------------
Assignee: Howard M. Lewis Ship
> The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice
> -------------------------------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-760) The Form event "validateForm" is
awkward, a new name (perhaps "formValidate") would be nice
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725821#action_12725821 ]
Massimo Lusetti commented on TAP5-760:
--------------------------------------
I really don't see a problem with the just-"validate" name.
> The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice
> -------------------------------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-760) The Form event "validateForm" is
awkward, a new name (perhaps "formValidate") would be nice
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725821#action_12725821 ]
Massimo Lusetti commented on TAP5-760:
--------------------------------------
I really don't see a problem with the just-"validate" name.
> The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice
> -------------------------------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-760) The Form event "validateForm" is
awkwardly named and should be replaced with the simpler name "validate"
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-760:
--------------------------------------
Summary: The Form event "validateForm" is awkwardly named and should be replaced with the simpler name "validate" (was: The Form event "validateForm" is awkward, just "validate" should do)
> The Form event "validateForm" is awkwardly named and should be replaced with the simpler name "validate"
> --------------------------------------------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.0
>
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-760) The Form event "validateForm" is
awkward, a new name (perhaps "formValidate") would be nice
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-760:
-----------------------------------------
Assignee: Howard M. Lewis Ship
> The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice
> -------------------------------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-760) The Form event "validateForm" is
awkward, just "validate" should do
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-760:
--------------------------------------
Summary: The Form event "validateForm" is awkward, just "validate" should do (was: The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice)
> The Form event "validateForm" is awkward, just "validate" should do
> -------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-760) The Form event "validateForm" is
awkward, just "validate" should do
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-760:
--------------------------------------
Summary: The Form event "validateForm" is awkward, just "validate" should do (was: The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice)
> The Form event "validateForm" is awkward, just "validate" should do
> -------------------------------------------------------------------
>
> Key: TAP5-760
> URL: https://issues.apache.org/jira/browse/TAP5-760
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.