[GitHub] [trafficcontrol] rob05c edited a comment on issue #4157: Wrong error code when requesting cdn ats configfile with bad ds id

[GitBox <gi...@apache.org>]

rob05c edited a comment on issue #4157: Wrong error code when requesting cdn ats configfile with bad ds id
URL: https://github.com/apache/trafficcontrol/pull/4157#issuecomment-561781449
 
 
   I agree, this is the right response code. But, it's currently serving a 500, and so does Perl.
   
   Would you mind if we held off on this, until we've been running the Config Generator for a little bit and are sure it's all working as expected?
   
   I've been trying to avoid changes from the Perl as much as possible, just for safety. The config gen is so much code, there's so much to go wrong. In theory, ORT shouldn't be requesting configs that don't exist. But it makes me anxious to make any change in behavior, until we've had this 20k lines of code running for a while.
   
   Again, I'm +1 on merging this in; I'd just like to wait on behavioral changes, until we've been running it and have confidence in it. Nobody can write 20,000 lines of code without a bug, myself included.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services