You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/05 11:59:57 UTC
[GitHub] [incubator-superset] elukey opened a new pull request #9471: Handle
empty dataframes in TableViz
elukey opened a new pull request #9471: Handle empty dataframes in TableViz
URL: https://github.com/apache/incubator-superset/pull/9471
TableViz fails to display empty dataframes returning an error like:
"None of [Index(['project', 'count'], dtype='object')] are in the [columns]"
The behavior has been observed while testing 0.36.0rc3 with
Druid datasources.
issue: #9468
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] elukey closed pull request #9471: Handle empty
dataframes in TableViz
Posted by GitBox <gi...@apache.org>.
elukey closed pull request #9471: Handle empty dataframes in TableViz
URL: https://github.com/apache/incubator-superset/pull/9471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on issue #9471:
Handle empty dataframes in TableViz
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #9471: Handle empty dataframes in TableViz
URL: https://github.com/apache/incubator-superset/pull/9471#issuecomment-609839067
Hmm, it's still not updating. @elukey can you rebase and force push to kickstart CI again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] elukey commented on issue #9471: Handle empty
dataframes in TableViz
Posted by GitBox <gi...@apache.org>.
elukey commented on issue #9471: Handle empty dataframes in TableViz
URL: https://github.com/apache/incubator-superset/pull/9471#issuecomment-609649909
> Thanks @elukey ! LGTM, I restarted the build as Travis apparently got stuck again.
Np! Happy to help :) Travis seems green if I follow the link, but the PR is still waiting..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9471: Handle
empty dataframes in TableViz
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9471: Handle empty dataframes in TableViz
URL: https://github.com/apache/incubator-superset/pull/9471#issuecomment-609839067
Hmm, it's still not updating. Can you rebase and force push to kickstart CI again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] elukey commented on issue #9471: Handle empty
dataframes in TableViz
Posted by GitBox <gi...@apache.org>.
elukey commented on issue #9471: Handle empty dataframes in TableViz
URL: https://github.com/apache/incubator-superset/pull/9471#issuecomment-609884809
Let me try to close this and re-open, maybe it helps :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] elukey commented on issue #9471: Handle empty
dataframes in TableViz
Posted by GitBox <gi...@apache.org>.
elukey commented on issue #9471: Handle empty dataframes in TableViz
URL: https://github.com/apache/incubator-superset/pull/9471#issuecomment-609879107
> Hmm, it's still not updating. @elukey can you rebase and force push to kickstart CI again?
Retried, and the build failed for some temporary issue (`The command "nvm install 10.14.2" failed and exited with 1 during .`) but it shows as not completed, not sure what is happening..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org