You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Ashwin Karpe (JIRA)" <ji...@apache.org> on 2010/07/14 06:56:51 UTC
[jira] Created: (CAMEL-2943) A Camel component that implements the
Telecom SIP protocol for Publish/Subscribe capability...
A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
-----------------------------------------------------------------------------------------------
Key: CAMEL-2943
URL: https://issues.apache.org/activemq/browse/CAMEL-2943
Project: Apache Camel
Issue Type: New Feature
Reporter: Ashwin Karpe
Assignee: Ashwin Karpe
The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2943) A Camel component that implements the
Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe resolved CAMEL-2943.
---------------------------------
Resolution: Fixed
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823_1.diff, camel-sip-20100823_1.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61332#action_61332 ]
Claus Ibsen commented on CAMEL-2943:
------------------------------------
There is some code which is commented out
{code}
+ /*public SipProvider getProvider() {
+ return provider;
+ }
+
+ public void setProvider(SipProvider provider) {
+ this.provider = provider;
+ }*/
{code}
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823.diff, camel-sip-20100823.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61340#action_61340 ]
Ashwin Karpe commented on CAMEL-2943:
-------------------------------------
Committed to the Subversion trunk as revision r988163
- Ashwin
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823_1.diff, camel-sip-20100823_1.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2943) A Camel component that implements the
Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2943:
--------------------------------
Attachment: (was: camel-sip.diff)
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823.diff, camel-sip-20100823.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2943) A Camel component that implements the
Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2943:
--------------------------------
Attachment: camel-sip.diff
camel-sip-20100714.zip
jain-sip.zip
Hi Claus, Hadrian & Willem,
I have developed an SIP component that supports the Publish/Subscribe pattern via a Presence Agent.
This component has been developed using the Jain-SIP API version 1.2. I have attached the supporting jars for your review (jain-sip.zip). Since the jars are not available in public Maven repositories, the jain-sip.zip file contains a shell script with commands to add the jars to a local repository. Once accepted these jars will need to be hosted via the public Apache Maven repository.
The jars are fully compatible with Apache License model and are releases by nist.gov. The links is given below
https://jain-sip.dev.java.net/
The JAIN-SIP Reference implementation is a product of the Advanced Networking Technologies Division at the National Institute of Standards and Technology (NIST). The JAIN SIP RI, TCK and tools published by this project are in the public domain.
A basic Presence Agent is also available with the Camel SIP component. This agent does not support persistence and other high end stateful capabilities seen with Telecom Presence Agents and is not intended for industrial use but rather for testing and proving out the capabilities of the SIP component and endpoints.
Can you please review and let me know what you think. I would be happy to incorporate any thoughts and comments you might have. When you think everything looks good, I will be happy to commit the changes to the trunk.
Cheers,
Ashwin...
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100714.zip, camel-sip.diff, jain-sip.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60671#action_60671 ]
Hadrian Zbarcea commented on CAMEL-2943:
----------------------------------------
A sip component is a very interesting one and I talked to Chris about this not long ago. For integration with a pbx we were looking at [asterisk-java|http://asterisk-java.org/]. Testing could be a bit of a problem as I am not aware of a mock and this may require some hardware/service to test.
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100714.zip, camel-sip.diff, jain-sip.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61333#action_61333 ]
Claus Ibsen commented on CAMEL-2943:
------------------------------------
The maven repo we have listed in our pom.xml should generally use the same id.
So can you lookup an existing component which uses the jboss repo such as camel-netty and use the same id as it?
{code}
<id>sip</id>
{code}
Nexus servers and whatnot requires to use consistent ids.
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823.diff, camel-sip-20100823.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on CAMEL-2943 started by Ashwin Karpe.
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2943) A Camel component that implements the
Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2943:
--------------------------------
Attachment: (was: jain-sip.zip)
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823.diff, camel-sip-20100823.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60655#action_60655 ]
Willem Jiang commented on CAMEL-2943:
-------------------------------------
Hi Ashwin,
I just found there are some jain-sip artifacts in http://download.java.net/maven/2/javax/sip, can you check if you can use them ?
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100714.zip, camel-sip.diff, jain-sip.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61335#action_61335 ]
Ashwin Karpe commented on CAMEL-2943:
-------------------------------------
Hi Claus,
I did run checkstyle. It did not seem to pick up anything. The earlier iteration did indeed get flagged by checkstyle.
Oh yikes!!. Did not see the commented code. Will remove right away. Will also make the change in the POM and use the same id for the JBoss repo.
Cheers,
Ashwin...
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823.diff, camel-sip-20100823.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2943) A Camel component that
implements the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61340#action_61340 ]
Ashwin Karpe edited comment on CAMEL-2943 at 8/23/10 12:08 PM:
---------------------------------------------------------------
Committed to the Subversion trunk as revision r988163
was (Author: akarpe):
Committed to the Subversion trunk as revision r988163
- Ashwin
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823_1.diff, camel-sip-20100823_1.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61134#action_61134 ]
Claus Ibsen commented on CAMEL-2943:
------------------------------------
What does this code do?
{code}
Integer.toHexString((int) (Math.random() * Integer.MAX_VALUE))
{code}
And if exceptions is thrown you catch and log them. Is this the best we can do?
Is an ACK anything but a 200?
{code}
if (response.getStatusCode() != 200) {
+ LOG.debug("Ack received from Subscriber");
+ }
{code}
There are a couple of places where you drop the message like this
{code}
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Stray response -- dropping ");
+ }
{code}
Maybe it should be WARN level? Or does this happen very often?
And maybe you can log a bit more about the stray response? So the end user have more information to track down with.
You may want to provide a better error message if a mandatory header is missing, as you can't see from the error message that its a header and what the key is for it
{code}
ObjectHelper.notNull(exchange.getIn().getHeader("REQUEST_METHOD"), "Request Method");
{code}
Instead of type casting use the Camel API for that
{code}
String requestMethod = (String) exchange.getIn().getHeader("REQUEST_METHOD");
{code}
Should just be
{code}
String requestMethod = exchange.getIn().getHeader("REQUEST_METHOD", String.class);
{code}
Should the doStop method in {{SipSubscriber}} be empty?
Also ensure the code is valid according to checkstyle using the mvn goal:
{code}
mvn compile -Psourcecheck
{code}
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100714.zip, camel-sip.diff, jain-sip.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61330#action_61330 ]
Ashwin Karpe commented on CAMEL-2943:
-------------------------------------
Hi Claus & Willem,
BTW, I also found that the JBoss Repository (same as Netty) keeps up-to-date versions of the Jain-Sip jars. I modified my POM and the parent/pom.xml to use the jar versions from this repository.
Now there is no need for the jars to be installed by hand or stored in the Camel repository.
Cheers,
Ashwin...
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823.diff, camel-sip-20100823.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60818#action_60818 ]
Ashwin Karpe commented on CAMEL-2943:
-------------------------------------
Hi Claus,
I just saw that the 2.4 release is now GA. Do you have any edits or comments on this component submission.
I would like to commit the changes and move on to other bugs/fixes and also add documentation etc.
Cheers,
Ashwin...
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100714.zip, camel-sip.diff, jain-sip.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61331#action_61331 ]
Claus Ibsen commented on CAMEL-2943:
------------------------------------
You should use {{CamelExchangeException}} if throwing a checked exception when something is wrong with the Exchange. Then it will automatic log some details about the exchange, so you just write what is wrong, such as a header is missing.
We could also consider adding {{getMandatoryHeader}} on the {{Message}} API if its to be used more? Then Camel will auto throw exception if the header is missing.
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823.diff, camel-sip-20100823.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2943) A Camel component that implements the
Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2943:
--------------------------------
Attachment: (was: camel-sip-20100823.diff)
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823_1.diff, camel-sip-20100823_1.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61334#action_61334 ]
Claus Ibsen commented on CAMEL-2943:
------------------------------------
And remember to run checkstyle as well.
Otherwise its great and a +1 from me.
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823.diff, camel-sip-20100823.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2943) A Camel component that implements the
Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2943:
--------------------------------
Attachment: camel-sip-20100823_1.diff
camel-sip-20100823_1.zip
Hi Claus,
Please find a new diff and zip file with the latest set of changes.
I have removed the commented API's (thanks for spotting that), updated the repository to the one used in Netty using the same ID. I also found a newer version of the sip jars (1.2.153). I have changed the link in the parent/pom.xml to use the latest version. I have also verified that the tests work fine against the newer version.
I have verified the code using sourcecheck (checkstyle) and everything is in order.
Cheers,
Ashwin...
P.S: I will be checking in this version of the code.
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823_1.diff, camel-sip-20100823_1.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60727#action_60727 ]
Ashwin Karpe commented on CAMEL-2943:
-------------------------------------
Hi Hadrian,
I used the OpenXCAP as part of an engagement to prove that the solution works. Unfortunately OpenXCAP has a GPL License version 2 which is not compatible with the Apache 2 License.
In the absence of this I developed my own presence agent which can be instantiated as an endpoint by the SIP component and used for Unit and Integration Testing. It works well and can be used to prove the capability of SIP endpoints doing publish/subscribe.
I have included a unit test with the SIP component that shows this in action.
Hope this helps.
Cheers,
Ashwin...
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100714.zip, camel-sip.diff, jain-sip.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61129#action_61129 ]
Ashwin Karpe commented on CAMEL-2943:
-------------------------------------
Hi All,
Can you please review and let me know if I can go ahead and commit this new component.
I have not had much feedback thus far and I am happy to make any changes based on your thoughts and comments.
Cheers,
Ashwin...
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100714.zip, camel-sip.diff, jain-sip.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2943) A Camel component that implements the
Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2943:
--------------------------------
Attachment: (was: camel-sip-20100823.zip)
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823_1.diff, camel-sip-20100823_1.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60646#action_60646 ]
Claus Ibsen commented on CAMEL-2943:
------------------------------------
Ashwin we will take a look after the dust of the Camel 2.4 release has settled.
Please refrain from committing big changes to the trunk, in case a new 2.4 release has to be cut etc. Its best to only commit bug fixes until the 2.4 is GA.
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100714.zip, camel-sip.diff, jain-sip.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2943) A Camel component that implements the
Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2943:
--------------------------------
Attachment: (was: camel-sip-20100714.zip)
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823.diff, camel-sip-20100823.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2943) A Camel component that implements
the Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60667#action_60667 ]
Ashwin Karpe commented on CAMEL-2943:
-------------------------------------
Hi Willem,
Cool, I was not aware of this site. I will check out my code using the jars on this site.
Cheers,
Ashwin...
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100714.zip, camel-sip.diff, jain-sip.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2943) A Camel component that implements the
Telecom SIP protocol for Publish/Subscribe capability...
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2943:
--------------------------------
Attachment: camel-sip-20100823.diff
camel-sip-20100823.zip
Hi Claus,
I have made all the changes based on your recommendations and am attaching a fresh snapshot for your review.
Can you please let me know what you think. The changes I have made are as follows
a> The line you identified was a spurious line (harmless though) that was replaced with the earlier line which used the UUID instead of a random value to set up the Tag for the SipStack.
b> Addressed this by adding a fresh interface that offers all the known SIP status codes (SipMessageCodes.java) and implementing it in the SipPresenceAgent. Also changed the code to
{code}
public synchronized void processResponse(ResponseEvent responseReceivedEvent) {
Response response = (Response) responseReceivedEvent.getResponse();
Integer statusCode = response.getStatusCode();
if (SIP_MESSAGE_CODES.containsKey(statusCode)) {
LOG.debug(SIP_MESSAGE_CODES.get(statusCode) + " received from Subscriber");
}
}
{code}
c> Changed the Log message to a Warning. The chances of this happening are low but can happen in the absence of a dialog or transaction...
d> Changed the code to deal with the missing Header situation in a better way.
{code}
String requestMethod = exchange.getIn().getHeader("REQUEST_METHOD", String.class);
if (requestMethod == null) {
throw new CamelException("Missing mandatory Header in REQUEST_HEADER in exchange");
}
{code}
e> Changed the typecast based on your recommendation. (see above code)
Hope this helps.
Cheers,
Ashwin...
> A Camel component that implements the Telecom SIP protocol for Publish/Subscribe capability...
> -----------------------------------------------------------------------------------------------
>
> Key: CAMEL-2943
> URL: https://issues.apache.org/activemq/browse/CAMEL-2943
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ashwin Karpe
> Assignee: Ashwin Karpe
> Attachments: camel-sip-20100823.diff, camel-sip-20100823.zip
>
>
> The Telco SIP protocol has operations to perform Publish and Subscribe of Telecom events via a Presence Agent (similar to a Broker) as an intermediary.
> Develop a Camel SIP Component that can communicate with a Presence Agent (also add a basic Presence Agent with no persistence). The SIP Component should as a consumer, subscribe to messages from a Presence Agent and support the SIP protocol handshake and as a Producer publish messages to a Presence Agent.
> The SIP protocol involves communication over HTTP with specific acknowledgements that need to cater for different situations. This communication pattern and handshake must be properly supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.