[GitHub] [lucene] dweiss commented on a change in pull request #63: LUCENE-9901: UnicodeData.java has no regeneration task

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #63:
URL: https://github.com/apache/lucene/pull/63#discussion_r606853227



##########
File path: buildSrc/scriptDepVersions.gradle
##########
@@ -0,0 +1,16 @@
+// Declare script dependency versions outside of palantir's
+// version unification control. These are not our main dependencies
+// but are reused in buildSrc and across applied scripts.
+
+ext {
+  scriptDepVersions = [
+      "apache-rat": "0.11",
+      "commons-codec": "1.13",
+      "ecj": "3.25.0",
+      "flexmark": "0.61.24",
+      "icu": "68.2",

Review comment:
       We can't because these dependencies are used from scripts, not through the "normal" dependency configurations. You could fork a separate JVM with proper dependencies, but this would involve a separate compilation pass, etc. I thought it'd be easier to maintain if just embedded directly in the script.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org