You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by hye <gi...@git.apache.org> on 2016/10/18 06:14:33 UTC
[GitHub] cordova-android pull request #342: CB-12028: (android) update distributionUr...
GitHub user hye opened a pull request:
https://github.com/apache/cordova-android/pull/342
CB-12028: (android) update distributionUrl , current return `403`
### Platforms affected
cordova-android
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
no need to do this.
[cordova-android/bin/templates/cordova/lib/builders/GradleBuilder.js#L166](https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GradleBuilder.js#L166)
current distributionUrl in http now return ` 403 `( Request forbidden by administrative rules.), and it did broke the `cordova build android` ,please change it to https,
hurry, please.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hye/cordova-android gradle-distributionUrl-patch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/342.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #342
----
commit 277f8a6d70a6759a1f15c20844a3169561ba58dd
Author: hye <hy...@users.noreply.github.com>
Date: 2016-10-17T17:19:59Z
CB-12028: (android) update distributionUrl , current return `403`
CB-12028: (android) update distributionUrl from http to https , http URL now return `403`
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #342: CB-12028: (android) update distributionUrl , cur...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-android/pull/342
@hye This has landed in another commit, can you close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #342: CB-12028: (android) update distributionUrl , cur...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/342
## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/342?src=pr) is 35.21% (diff: 100%)
> Merging [#342](https://codecov.io/gh/apache/cordova-android/pull/342?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will not change coverage
```diff
@@ master #342 diff @@
==========================================
Files 12 12
Lines 1028 1028
Methods 202 202
Messages 0 0
Branches 169 169
==========================================
Hits 362 362
Misses 666 666
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [0b710a8...277f8a6](https://codecov.io/gh/apache/cordova-android/compare/0b710a86a9819438d0df7226241995b8887e227d...277f8a6d70a6759a1f15c20844a3169561ba58dd?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #342: CB-12028: (android) update distributionUr...
Posted by hye <gi...@git.apache.org>.
Github user hye closed the pull request at:
https://github.com/apache/cordova-android/pull/342
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org