You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Eran Chinthaka (JIRA)" <ji...@apache.org> on 2005/08/10 05:05:37 UTC
[jira] Created: (AXIS2-135) Comments handling in saaj.TextImpl
Comments handling in saaj.TextImpl
----------------------------------
Key: AXIS2-135
URL: http://issues.apache.org/jira/browse/AXIS2-135
Project: Apache Axis 2.0 (Axis2)
Type: Bug
Components: om
Reporter: Eran Chinthaka
Priority: Minor
org.apache.axis2.saaj.TextImpl - Line 83. What if the text contains something like "<!--some comment --> some other text". Will this be considered as a comment or simple text ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (AXIS2-135) Comments handling in saaj.TextImpl
Posted by "Ashutosh Shahi (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-135?page=comments#action_12318273 ]
Ashutosh Shahi commented on AXIS2-135:
--------------------------------------
OK, its already working that way. I'll add a test case to show that.
Ashutosh
> Comments handling in saaj.TextImpl
> ----------------------------------
>
> Key: AXIS2-135
> URL: http://issues.apache.org/jira/browse/AXIS2-135
> Project: Apache Axis 2.0 (Axis2)
> Type: Bug
> Components: om
> Reporter: Eran Chinthaka
> Assignee: Ashutosh Shahi
> Priority: Minor
>
> org.apache.axis2.saaj.TextImpl - Line 83. What if the text contains something like "<!--some comment --> some other text". Will this be considered as a comment or simple text ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (AXIS2-135) Comments handling in saaj.TextImpl
Posted by "Ashutosh Shahi (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-135?page=comments#action_12318265 ]
Ashutosh Shahi commented on AXIS2-135:
--------------------------------------
Well, obviously currently it is not. But what is the expected behaviour? I think it should not be taken as comment.
I'll anyway add a test acse for the same depending on what the expected behaviour is.
Ashutosh
> Comments handling in saaj.TextImpl
> ----------------------------------
>
> Key: AXIS2-135
> URL: http://issues.apache.org/jira/browse/AXIS2-135
> Project: Apache Axis 2.0 (Axis2)
> Type: Bug
> Components: om
> Reporter: Eran Chinthaka
> Priority: Minor
>
> org.apache.axis2.saaj.TextImpl - Line 83. What if the text contains something like "<!--some comment --> some other text". Will this be considered as a comment or simple text ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (AXIS2-135) Comments handling in saaj.TextImpl
Posted by "Eran Chinthaka (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-135?page=all ]
Eran Chinthaka resolved AXIS2-135:
----------------------------------
Resolution: Fixed
Sorry, I misunderstood the thing. By the time it gets to SAAJ, OM text only contains a comment within it .
> Comments handling in saaj.TextImpl
> ----------------------------------
>
> Key: AXIS2-135
> URL: http://issues.apache.org/jira/browse/AXIS2-135
> Project: Apache Axis 2.0 (Axis2)
> Type: Bug
> Components: om
> Reporter: Eran Chinthaka
> Assignee: Ashutosh Shahi
> Priority: Minor
>
> org.apache.axis2.saaj.TextImpl - Line 83. What if the text contains something like "<!--some comment --> some other text". Will this be considered as a comment or simple text ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (AXIS2-135) Comments handling in saaj.TextImpl
Posted by "Ashutosh Shahi (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-135?page=all ]
Ashutosh Shahi reassigned AXIS2-135:
------------------------------------
Assign To: Ashutosh Shahi
> Comments handling in saaj.TextImpl
> ----------------------------------
>
> Key: AXIS2-135
> URL: http://issues.apache.org/jira/browse/AXIS2-135
> Project: Apache Axis 2.0 (Axis2)
> Type: Bug
> Components: om
> Reporter: Eran Chinthaka
> Assignee: Ashutosh Shahi
> Priority: Minor
>
> org.apache.axis2.saaj.TextImpl - Line 83. What if the text contains something like "<!--some comment --> some other text". Will this be considered as a comment or simple text ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (AXIS2-135) Comments handling in saaj.TextImpl
Posted by "Eran Chinthaka (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-135?page=comments#action_12318271 ]
Eran Chinthaka commented on AXIS2-135:
--------------------------------------
I think if we have something like
<foo>this is some text <!-- This is a comment --> this is some other text</foo>
this should be considered as element foo having three chidlren, OMText, OMComment and OMText respectively.
> Comments handling in saaj.TextImpl
> ----------------------------------
>
> Key: AXIS2-135
> URL: http://issues.apache.org/jira/browse/AXIS2-135
> Project: Apache Axis 2.0 (Axis2)
> Type: Bug
> Components: om
> Reporter: Eran Chinthaka
> Assignee: Ashutosh Shahi
> Priority: Minor
>
> org.apache.axis2.saaj.TextImpl - Line 83. What if the text contains something like "<!--some comment --> some other text". Will this be considered as a comment or simple text ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (AXIS2-135) Comments handling in saaj.TextImpl
Posted by "Venkat Reddy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-135?page=comments#action_12318294 ]
Venkat Reddy commented on AXIS2-135:
------------------------------------
Isn't this decomposition to be handled by the XML parser? Or may be by Model builder? I think SAAJ Text object should not have to parse its content again looking for such compelx possiblities. If its content begins and ends with comment delimiters, its a comment node.
- venkat
> Comments handling in saaj.TextImpl
> ----------------------------------
>
> Key: AXIS2-135
> URL: http://issues.apache.org/jira/browse/AXIS2-135
> Project: Apache Axis 2.0 (Axis2)
> Type: Bug
> Components: om
> Reporter: Eran Chinthaka
> Assignee: Ashutosh Shahi
> Priority: Minor
>
> org.apache.axis2.saaj.TextImpl - Line 83. What if the text contains something like "<!--some comment --> some other text". Will this be considered as a comment or simple text ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira