You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/26 03:39:22 UTC

[GitHub] [iceberg] lipusheng opened a new pull request #3806: update 'Result type' of 'Partitions Transform' with name 'day' to be 'int'

lipusheng opened a new pull request #3806:
URL: https://github.com/apache/iceberg/pull/3806


   update  'Result type' of 'Partitions Transform' with name 'day' to be 'int'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #3806: update 'Result type' of 'Partitions Transform' with name 'day' to be 'int'

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3806:
URL: https://github.com/apache/iceberg/pull/3806#issuecomment-1003202719


   The return type is date because the int that is returned is a valid date. Using the return type `date` makes it so that Spark and other engines show the value correctly, rather than just showing an integer date ordinal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] lipusheng commented on pull request #3806: update 'Result type' of 'Partitions Transform' with name 'day' to be 'int'

Posted by GitBox <gi...@apache.org>.
lipusheng commented on pull request #3806:
URL: https://github.com/apache/iceberg/pull/3806#issuecomment-1002858253


   @kbendick can you help me merge this pull request, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue closed pull request #3806: update 'Result type' of 'Partitions Transform' with name 'day' to be 'int'

Posted by GitBox <gi...@apache.org>.
rdblue closed pull request #3806:
URL: https://github.com/apache/iceberg/pull/3806


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org