You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Ormod <gi...@git.apache.org> on 2017/09/07 13:49:11 UTC

[GitHub] zookeeper pull request #362: zookeeper: Use PKG_CHECK_MODULES to detect the ...

GitHub user Ormod opened a pull request:

    https://github.com/apache/zookeeper/pull/362

    zookeeper: Use PKG_CHECK_MODULES to detect the presence of cppunit

    Support for it has been removed from upstream, and 10+ year old
    cppunit's support the newer syntax. Move on to that.
    
    Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1311694

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aiven/zookeeper branch-3.5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #362
    
----
commit 609d94e8d8837fb445952c18d90da77102cc967e
Author: Hannu Valtonen <ha...@aiven.io>
Date:   2017-09-07T13:24:05Z

    zookeeper: Use PKG_CHECK_MODULES to detect the presence of cppunit
    
    Support for it has been removed from upstream, and 10+ year old
    cppunit's support the newer syntax. Move on to that.
    
    Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1311694

----


---

[GitHub] zookeeper issue #362: zookeeper: Use PKG_CHECK_MODULES to detect the presenc...

Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/362
  
    Haven't tried this locally, but Jenkins complains with this:
    `     [exec] BUILD FAILED
         [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1305: The following error occurred while executing this line:
         [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1315: exec returned: 2
         [exec] 
         [exec] Total time: 11 minutes 13 seconds
         [exec]      [exec] libtool: link: g++ -DUSE_STATIC_LIB -DZKSERVER_CMD=\"/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/tests/zkServer.sh\" -DZOO_IPV6_ENABLED -g -O2 -Wl,--wrap -Wl,calloc -Wl,--wrap -Wl,free -Wl,--wrap -Wl,flush_send_queue -Wl,--wrap -Wl,get_xid -Wl,--wrap -Wl,deliverWatchers -Wl,--wrap -Wl,activateWatcher -Wl,--wrap -Wl,realloc -o zktest-st zktest_st-TestDriver.o zktest_st-LibCMocks.o zktest_st-LibCSymTable.o zktest_st-MocksBase.o zktest_st-ZKMocks.o zktest_st-Util.o zktest_st-ThreadingUtil.o zktest_st-TestZookeeperInit.o zktest_st-TestZookeeperClose.o zktest_st-TestReconfig.o zktest_st-TestReconfigServer.o zktest_st-TestClientRetry.o zktest_st-TestOperations.o zktest_st-TestMulti.o zktest_st-TestWatchers.o zktest_st-TestClient.o zktest_st-ZooKeeperQuorumServer.o zktest_st-TestReadOnlyClient.o  ./.libs/libzkst.a -lm -lrt ./.libs/libhashtable.a -lcppunit
         [exec]      [exec] make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/test/test-cppunit'
         [exec]      [exec] /usr/bin/ld: zktest_st-LibCSymTable.o: undefined reference to symbol 'dlsym@@GLIBC_2.2.5'
         [exec]      [exec] //lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from command line
         [exec]      [exec] collect2: error: ld returned 1 exit status
         [exec]      [exec] make[1]: *** [zktest-st] Error 1
         [exec]      [exec] make: *** [check-am] Error 2`
    
    Please investigate.


---

[GitHub] zookeeper issue #362: zookeeper: Use PKG_CHECK_MODULES to detect the presenc...

Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/362
  
    I'm afraid the history was deleted on the Jenkins service. Can you resubmit the PR? Perhaps just rebase it to the current branch head and re-submit. That should kick off a Jenkins build.


---

[GitHub] zookeeper issue #362: zookeeper: Use PKG_CHECK_MODULES to detect the presenc...

Posted by Ormod <gi...@git.apache.org>.
Github user Ormod commented on the issue:

    https://github.com/apache/zookeeper/pull/362
  
    Sorry for the delay in answering, how can I find out the platform on which the build is failing? (in order to fix it it would be great to be able to repro at will)


---