Re: [PR] FINERACT-1971: Swagger classes primary keys fix [fineract]

["galovics (via GitHub)" <gi...@apache.org>]

galovics commented on code in PR #3545:
URL: https://github.com/apache/fineract/pull/3545#discussion_r1377285669


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/api/AccountTransfersApiResourceSwagger.java:
##########
@@ -39,13 +39,13 @@ static final class GetAccountTransfersFromOffice {
             private GetAccountTransfersFromOffice() {}
 
             @Schema(example = "1")
-            public Integer id;
+            public Long id;
             @Schema(example = "HO")
             public String name;
             @Schema(example = "HO")
             public String nameDecorated;
             @Schema(example = "1")
-            public Integer externalId;
+            public Long externalId;

Review Comment:
   Done.



##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/api/AccountTransfersApiResourceSwagger.java:
##########
@@ -298,13 +298,13 @@ static final class GetAccountTransfersTemplateRefundByTransferFromOffice {
             private GetAccountTransfersTemplateRefundByTransferFromOffice() {}
 
             @Schema(example = "1")
-            public Integer id;
+            public Long id;
             @Schema(example = "Head Office")
             public String name;
             @Schema(example = "Head Office")
             public String nameDecorated;
             @Schema(example = "1")
-            public Integer externalId;
+            public Long externalId;

Review Comment:
   Done.



##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/api/ChargesApiResourceSwagger.java:
##########
@@ -52,7 +52,7 @@ static final class GetChargesTimeTypeResponse {
             private GetChargesTimeTypeResponse() {}
 
             @Schema(example = "1")
-            public Long id;
+            public Integer id;

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org