You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "mercyblitz (GitHub)" <gi...@apache.org> on 2018/10/18 02:24:39 UTC
[GitHub] [incubator-dubbo] mercyblitz opened pull request #2655:
@Service and @Reference Optimization
## What is the purpose of the change
- [Enhancement] Reactor the generation rule for @Service Bean name #2235
- [Feature] Introduce a new Spring ApplicationEvent for ServiceBean exporting #2251
- [Bug Fix] apache/incubator-dubbo-spring-boot-project#243
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2655 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zonghaishang commented on pull request
#2655: @Service and @Reference Optimization
Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
Use `StringUtils.isNotEmpty` maybe better.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2655 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zonghaishang commented on pull request
#2655: @Service and @Reference Optimization
Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
remove * please.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2655 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] mercyblitz closed pull request #2655:
@Service and @Reference Optimization
Posted by "mercyblitz (GitHub)" <gi...@apache.org>.
[ pull request closed by mercyblitz ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2655 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zonghaishang commented on pull request
#2655: @Service and @Reference Optimization
Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
Multiple services referencing the same field here will cause a bug， see: https://github.com/apache/incubator-dubbo/commit/d8282fe1b8075a453c7b44b4ae7982a4285df7b7
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2655 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zonghaishang commented on pull request
#2655: @Service and @Reference Optimization
Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
Multiple services referencing the same field here will cause a bug， see: https://github.com/apache/incubator-dubbo/commit/d8282fe1b8075a453c7b44b4ae7982a4285df7b7
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2655 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zonghaishang commented on pull request
#2655: @Service and @Reference Optimization
Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
Maybe you should use dubbo code style here ? you can found here : https://github.com/apache/incubator-dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml
remove `*` please.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2655 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org