You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Geoffrey Young <ge...@modperlcookbook.org> on 2003/08/11 15:56:42 UTC

Re: 5.8.1-RC4 status


Stas Bekman wrote:
> Geoffrey Young wrote:
> 
>> I haven't been following p5p that well lately, but what is the status 
>> of 5.8.1-RC4 wrt mod_perl.
>>
>> I, for one, cannot get RC4 (or bleedperl) to work with worker on 2.0 
>> or 2.1
>>
>> I thought the problematic hash stuff was removed in RC3?
> 
> 
> I built an exact same perl and tried with the latest httpd-2.0 (haven't 
> tried 2.1), but using patch level 20562 and it worked just fine (both 
> worker and prefork). Can you please try with 20562 (it's post-RC4).
> 
> You can get the latest patchlevel, using the following:
> 
> rsync -acvz --delete --force 
> rsync://ftp.linux.activestate.com/perl-5.8.x ./perl-5.8.1

ok, I just finished doing that, though perl is now patch level 20581.  I 
still see the problem.

after some investigation, I don't think it's perl.  if I set PERL_HASH_SEED 
to some value, everything is ok, and this patch fixes the segfault

--- src/modules/perl/mod_perl.c 6 Aug 2003 06:46:35 -0000       1.175
+++ src/modules/perl/mod_perl.c 11 Aug 2003 13:52:58 -0000
@@ -33,7 +33,7 @@
      /* check if there is a specific hash seed passed via the env var
       * and if that's the case -- use it */
      apr_status_t rv = apr_env_get(&s, "PERL_HASH_SEED", p);
-    if (rv != APR_ENOTIMPL) {
+    if (rv == APR_SUCCESS) {

which seems like a better check anyway.

so, maybe you have PERL_HASH_SEED set in your env someplace?

--Geoff


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: 5.8.1-RC4 status

Posted by Geoffrey Young <ge...@modperlcookbook.org>.
>> after some investigation, I don't think it's perl.  if I set 
>> PERL_HASH_SEED to some value, everything is ok, and this patch fixes 
>> the segfault
>>
>> --- src/modules/perl/mod_perl.c 6 Aug 2003 06:46:35 -0000       1.175
>> +++ src/modules/perl/mod_perl.c 11 Aug 2003 13:52:58 -0000
>> @@ -33,7 +33,7 @@
>>      /* check if there is a specific hash seed passed via the env var
>>       * and if that's the case -- use it */
>>      apr_status_t rv = apr_env_get(&s, "PERL_HASH_SEED", p);
>> -    if (rv != APR_ENOTIMPL) {
>> +    if (rv == APR_SUCCESS) {
>>
>> which seems like a better check anyway.
> 
> 
> Sounds good, since this is optional. please commit.

done

> 
> So with this patch everything works just fine without you setting 
> PERL_HASH_SEED? 

yup, with and without random PERL_HASH_SEED values in my env, as well as odd 
values such as 0 and just PERL_HASH_SEED=

> May be it should do:
> 
> while (s && isSPACE(*s)) s++;

when it comes to C style, I have no opinions (yet :)

> 
>> so, maybe you have PERL_HASH_SEED set in your env someplace?
> 
> 
> No, I don't have it.

hmph.

--Geoff


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: 5.8.1-RC4 status

Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
> 
> 
> Stas Bekman wrote:
> 
>> Geoffrey Young wrote:
>>
>>> I haven't been following p5p that well lately, but what is the status 
>>> of 5.8.1-RC4 wrt mod_perl.
>>>
>>> I, for one, cannot get RC4 (or bleedperl) to work with worker on 2.0 
>>> or 2.1
>>>
>>> I thought the problematic hash stuff was removed in RC3?
>>
>>
>>
>> I built an exact same perl and tried with the latest httpd-2.0 
>> (haven't tried 2.1), but using patch level 20562 and it worked just 
>> fine (both worker and prefork). Can you please try with 20562 (it's 
>> post-RC4).
>>
>> You can get the latest patchlevel, using the following:
>>
>> rsync -acvz --delete --force 
>> rsync://ftp.linux.activestate.com/perl-5.8.x ./perl-5.8.1
> 
> 
> ok, I just finished doing that, though perl is now patch level 20581.  I 
> still see the problem.
> 
> after some investigation, I don't think it's perl.  if I set 
> PERL_HASH_SEED to some value, everything is ok, and this patch fixes the 
> segfault
> 
> --- src/modules/perl/mod_perl.c 6 Aug 2003 06:46:35 -0000       1.175
> +++ src/modules/perl/mod_perl.c 11 Aug 2003 13:52:58 -0000
> @@ -33,7 +33,7 @@
>      /* check if there is a specific hash seed passed via the env var
>       * and if that's the case -- use it */
>      apr_status_t rv = apr_env_get(&s, "PERL_HASH_SEED", p);
> -    if (rv != APR_ENOTIMPL) {
> +    if (rv == APR_SUCCESS) {
> 
> which seems like a better check anyway.

Sounds good, since this is optional. please commit.

So with this patch everything works just fine without you setting 
PERL_HASH_SEED? May be it should do:

while (s && isSPACE(*s)) s++;

> so, maybe you have PERL_HASH_SEED set in your env someplace?

No, I don't have it.



__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org