You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/01/10 05:01:29 UTC
[GitHub] weichao666 commented on a change in pull request #499: [SCB-214] AbstractServiceRegistry findServiceInstance process null return value, not print too much exception
weichao666 commented on a change in pull request #499: [SCB-214] AbstractServiceRegistry findServiceInstance process null return value, not print too much exception
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/499#discussion_r160590155
##########
File path: service-registry/src/main/java/io/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##########
@@ -169,10 +169,16 @@ private void retry(RequestContext requestContext, Handler<RestResponse> response
bodyBuffer -> {
try {
mInstances.setRevision(response.getHeader("X-Resource-Revision"));
Review comment:
[2018-01-10 12:40:56,382/GMT+08:00][main][INFO]running microservice register task. io.servicecomb.serviceregistry.task.MicroserviceRegisterTask.doRegister(MicroserviceRegisterTask.java:58)
[2018-01-10 12:40:56,413/GMT+08:00][main][INFO]Using the default address resolver as the dns resolver could not be loaded io.vertx.core.spi.resolver.ResolverProvider.factory(ResolverProvider.java:51)
[2018-01-10 12:40:56,632/GMT+08:00][registry-vert.x-eventloop-thread-0][ERROR]{"errorCode":"400012","errorMessage":"Micro-service does not exist","detail":"Service does not exist."}
io.servicecomb.serviceregistry.client.http.ServiceRegistryClientImpl.lambda$10(ServiceRegistryClientImpl.java:115)
[2018-01-10 12:40:56,679/GMT+08:00][main][INFO]Registry Microservice successfully. id=72ccb9b6f5c011e78b1c286ed4891d48 appId=springmvctest, name=springmvc, version=0.0.3, schemaIds=[controller, metricsEndpoint, codeFirst] io.servicecomb.serviceregistry.task.MicroserviceRegisterTask.doRegister(MicroserviceRegisterTask.java:90)
when 400, syncHandler just print a line code,
from the result of print exception, it looks like no need to modified.
but if think it from whether read json,can it be modified like below?
if (response.statusCode() == 200) {
try {
holder.value =
JsonUtils.readValue(bodyBuffer.getBytes(), cls);
} catch (Exception e) {
LOGGER.warn("read value failed and response message is {}",
bodyBuffer.toString());
}
} else {
LOGGER.warn(bodyBuffer.toString());
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services