[jira] Commented: (TRINIDAD-1109) Support non-standard user agents

["Andrew Robinson (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TRINIDAD-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615328#action_12615328 ] 

Andrew Robinson commented on TRINIDAD-1109:
-------------------------------------------

Do you all think that a possible work-around/enhancement is to create an "OTHER" or "UNKNOWN" agent? This way we could add more agents as necessary, but still allow people to skin for non-supported browsers.

> Support non-standard user agents
> --------------------------------
>
>                 Key: TRINIDAD-1109
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1109
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Skinning
>    Affects Versions:  1.0.8-core,  1.2.8-core
>         Environment: User agent string: Mozilla/5.0 (compatible; Konqueror/3.5; Linux) KHTML/3.5.9 (like Gecko)
>            Reporter: Alexey Stukalov
>
> Trinidad should be able to render the request for non-supported user agents.
> Since 1.x.9 version, user agent's version is mandatory.
> If user agent is not recognized and its version is not set, exceptions are thrown:
>   1) on initial request - "version must be non-null" NPE in org.apache.myfaces.trinidad.context.Version._checkNonEmptyString(Version.java:197)
>   2) on subsequent requests - NPE in org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$Key.hashCode(FileSystemStyleCache.java:1131)
> The proposed policy is to provide "default" rendering for those agent's that are not recognized/partially recognized (agent type or platform identified, but not version etc).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.