[jira] [Commented] (AMBARI-16272) Ambari Upgrade shouldn't automatically add stack configs

["Tim Thorpe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311069#comment-15311069 ] 

Tim Thorpe commented on AMBARI-16272:
-------------------------------------

This seems to have broken the StackManager tests

Running org.apache.ambari.server.stack.StackManagerTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.884 sec <<< FAILURE! - in org.apache.ambari.server.stack.StackManag
org.apache.ambari.server.stack.StackManagerTest  Time elapsed: 0.883 sec  <<< ERROR!
org.apache.ambari.server.AmbariException: File /home/tim/dev/workspaces/stackext/ambari/ambari-server/target/test-classes/stacks/HDP/ration/hdfs-site.xml didn't pass the validation. Error message is : cvc-complex-type.2.4.a: Invalid content was found starting with e'{display-name, filename, deleted, on-ambari-upgrade, on-stack-upgrade, property-type, value-attributes, depends-on, property_depende
        at org.apache.ambari.server.stack.StackManagerTest.createTestStackManager(StackManagerTest.java:123)
        at org.apache.ambari.server.stack.StackManagerTest.createTestStackManager(StackManagerTest.java:94)
        at org.apache.ambari.server.stack.StackManagerTest.initStack(StackManagerTest.java:89)


> Ambari Upgrade shouldn't automatically add stack configs
> --------------------------------------------------------
>
>                 Key: AMBARI-16272
>                 URL: https://issues.apache.org/jira/browse/AMBARI-16272
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>    Affects Versions: 2.4.0
>            Reporter: Dmitry Lysnichenko
>            Assignee: Dmitry Lysnichenko
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-16272.patch
>
>
> Today, Ambari Upgrade will automatically add stack configs.
> However, it also causes problems when default properties or properties with default value such as "localhost" end up being added.
> This led to many bugs. E.g., cluster with NameNode HA shouldn't automatically add dfs.namenode.secondary.http-address
> Properties should be explicitly added during RU/EU config packs instead of relying on annotating them with.
> {code}
> <property-type>DONT_ADD_ON_UPGRADE</property-type>
> {code}
> This logic today will even add new config types. E.g., add ranger-env even though Ranger is not installed. If the customer then upgrades the stack from HDP 2.2 to 2.3, and then adds Ranger, they can get the wrong configs.
> If we change this behavior, it's good to do so in a major release such as 2.4
> We add required xml tags to properties:
> # If it's a new property from stack X to X+1, we don't want it to be added automatically added. If we do want to add it, we should annotate it with "ADD_ON_UPGRADE"
> # Similar to above, but handle "DELETE_ON_UPGRADE"
> # Similar to above, but handle "CHANGE_ON_UPGRADE" to forcefully set to a new value if it exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)