You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ni...@apache.org on 2008/09/25 09:10:42 UTC
svn commit: r698841 - in /activemq/camel/trunk:
camel-core/src/main/java/org/apache/camel/
camel-core/src/main/java/org/apache/camel/impl/converter/
camel-core/src/test/java/org/apache/camel/processor/
components/camel-http/src/main/java/org/apache/cam...
Author: ningjiang
Date: Thu Sep 25 00:10:41 2008
New Revision: 698841
URL: http://svn.apache.org/viewvc?rev=698841&view=rev
Log:
CAMEL-716 better logger information for the NoClassDefFoundError
Modified:
activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/NoSuchEndpointException.java
activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/AnnotationTypeConverterLoader.java
activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/processor/DeadLetterChannelTest.java
activemq/camel/trunk/components/camel-http/src/main/java/org/apache/camel/component/http/HttpProducer.java
activemq/camel/trunk/components/camel-script/src/main/java/org/apache/camel/builder/script/ScriptBuilder.java
Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/NoSuchEndpointException.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/NoSuchEndpointException.java?rev=698841&r1=698840&r2=698841&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/NoSuchEndpointException.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/NoSuchEndpointException.java Thu Sep 25 00:10:41 2008
@@ -29,7 +29,9 @@
private final String uri;
public NoSuchEndpointException(String uri) {
- super("No endpoint could be found for: " + uri);
+ super("No endpoint could be found for: " + uri
+ + ", please check the class path for the uri relates camel component module.");
+
this.uri = uri;
}
Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/AnnotationTypeConverterLoader.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/AnnotationTypeConverterLoader.java?rev=698841&r1=698840&r2=698841&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/AnnotationTypeConverterLoader.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/AnnotationTypeConverterLoader.java Thu Sep 25 00:10:41 2008
@@ -176,7 +176,7 @@
loadConverterMethods(registry, superclass);
}
} catch (NoClassDefFoundError e) {
- LOG.debug("Ignoring converter type: " + type.getName() + " as a dependent class could not be found: " + e, e);
+ LOG.warn("Ignoring converter type: " + type.getName() + " as a dependent class could not be found: " + e, e);
}
}
Modified: activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/processor/DeadLetterChannelTest.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/processor/DeadLetterChannelTest.java?rev=698841&r1=698840&r2=698841&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/processor/DeadLetterChannelTest.java (original)
+++ activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/processor/DeadLetterChannelTest.java Thu Sep 25 00:10:41 2008
@@ -50,7 +50,8 @@
deadEndpoint.expectedBodiesReceived(body);
deadEndpoint.message(0).header(DeadLetterChannel.REDELIVERED).isEqualTo(true);
- deadEndpoint.message(0).header(DeadLetterChannel.REDELIVERY_COUNTER).isEqualTo(2); successEndpoint.expectedMessageCount(0);
+ deadEndpoint.message(0).header(DeadLetterChannel.REDELIVERY_COUNTER).isEqualTo(2);
+ successEndpoint.expectedMessageCount(0);
sendBody("direct:start", body);
@@ -82,7 +83,7 @@
if (attempt < failUntilAttempt) {
throw new RuntimeException("Failed to process due to attempt: " + attempt
+ " being less than: " + failUntilAttempt);
- }
+ }
}
};
Modified: activemq/camel/trunk/components/camel-http/src/main/java/org/apache/camel/component/http/HttpProducer.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-http/src/main/java/org/apache/camel/component/http/HttpProducer.java?rev=698841&r1=698840&r2=698841&view=diff
==============================================================================
--- activemq/camel/trunk/components/camel-http/src/main/java/org/apache/camel/component/http/HttpProducer.java (original)
+++ activemq/camel/trunk/components/camel-http/src/main/java/org/apache/camel/component/http/HttpProducer.java Thu Sep 25 00:10:41 2008
@@ -82,8 +82,8 @@
bos.flush();
is.close();
out.setBody(bos.createInputStream());
-
- // propagate HTTP response headers
+
+ // propagate HTTP response headers
Header[] headers = method.getResponseHeaders();
for (Header header : headers) {
String name = header.getName();
@@ -110,10 +110,10 @@
RequestEntity requestEntity = createRequestEntity(exchange);
Object m = exchange.getIn().getHeader(HTTP_METHOD);
-
+
HttpMethods ms = requestEntity == null ? HttpMethods.GET : HttpMethods.POST;
- ms = m instanceof HttpMethods ? (HttpMethods)m :
- m == null ? ms : HttpMethods.valueOf(m.toString());
+ ms = m instanceof HttpMethods ? (HttpMethods)m
+ : m == null ? ms : HttpMethods.valueOf(m.toString());
HttpMethod method = ms.createMethod(uri);
Modified: activemq/camel/trunk/components/camel-script/src/main/java/org/apache/camel/builder/script/ScriptBuilder.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-script/src/main/java/org/apache/camel/builder/script/ScriptBuilder.java?rev=698841&r1=698840&r2=698841&view=diff
==============================================================================
--- activemq/camel/trunk/components/camel-script/src/main/java/org/apache/camel/builder/script/ScriptBuilder.java (original)
+++ activemq/camel/trunk/components/camel-script/src/main/java/org/apache/camel/builder/script/ScriptBuilder.java Thu Sep 25 00:10:41 2008
@@ -501,7 +501,15 @@
protected ScriptEngine createScriptEngine() {
ScriptEngineManager manager = new ScriptEngineManager();
- ScriptEngine engine = manager.getEngineByName(scriptEngineName);
+ try {
+ engine = manager.getEngineByName(scriptEngineName);
+ } catch (NoClassDefFoundError ex) {
+ LOG.error("Can't load the scriptEngine for " + scriptEngineName + ", the exception is " + ex
+ + ", please check the scriptEngine needs jars.");
+ }
+ if (engine == null) {
+ throw new IllegalArgumentException("No script engine could be created for: " + getScriptEngineName());
+ }
if (isPython()) {
ScriptContext context = engine.getContext();
context.setAttribute("com.sun.script.jython.comp.mode", "eval", ScriptContext.ENGINE_SCOPE);