You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2009/01/11 14:43:51 UTC

Re: svn commit: r35145 - in trunk/subversion: libsvn_client tests/cmdline

On Sun, Jan 11, 2009 at 06:06, Bert Huijben <rh...@sharpsvn.net> wrote:
>...
> +++ trunk/subversion/libsvn_client/add.c        Sun Jan 11 06:06:31 2009        (r35145)
> @@ -467,18 +467,23 @@ add_parent_dirs(const char *path,
>
>   if (err && err->apr_err == SVN_ERR_WC_NOT_DIRECTORY)
>     {
> +      svn_error_clear(err);
>       if (svn_dirent_is_root(path, strlen(path)))
>         {
> -          svn_error_clear(err);
> -
>           return svn_error_create
>             (SVN_ERR_CLIENT_NO_VERSIONED_PARENT, NULL, NULL);
>         }
> +      else if(svn_wc_is_adm_dir(svn_dirent_basename(path, pool), pool))

"if" is not a function. there should be a space in there.

>...

Cheers,
-g

RE: svn commit: r35145 - in trunk/subversion: libsvn_client tests/cmdline

Posted by Bert Huijben <rh...@sharpsvn.net>.
> -----Original Message-----
> From: Greg Stein [mailto:gstein@gmail.com]
> Sent: Sunday, January 11, 2009 3:44 PM
> To: dev@subversion.tigris.org
> Subject: Re: svn commit: r35145 - in trunk/subversion: libsvn_client
> tests/cmdline
> 
> On Sun, Jan 11, 2009 at 06:06, Bert Huijben <rh...@sharpsvn.net>
> wrote:
> >...
> > +++ trunk/subversion/libsvn_client/add.c        Sun Jan 11 06:06:31
> 2009        (r35145)
> > @@ -467,18 +467,23 @@ add_parent_dirs(const char *path,
> >
> >   if (err && err->apr_err == SVN_ERR_WC_NOT_DIRECTORY)
> >     {
> > +      svn_error_clear(err);
> >       if (svn_dirent_is_root(path, strlen(path)))
> >         {
> > -          svn_error_clear(err);
> > -
> >           return svn_error_create
> >             (SVN_ERR_CLIENT_NO_VERSIONED_PARENT, NULL, NULL);
> >         }
> > +      else if(svn_wc_is_adm_dir(svn_dirent_basename(path, pool),
> pool))
> 
> "if" is not a function. there should be a space in there.

r35149.

Thanks,
	Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1017151