You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/25 00:16:00 UTC

[jira] [Commented] (NIFI-5451) Modify NiFiGroovyTest.groovy to avoid needing unlimited strength JCE policy

    [ https://issues.apache.org/jira/browse/NIFI-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554928#comment-16554928 ] 

ASF GitHub Bot commented on NIFI-5451:
--------------------------------------

GitHub user alopresto opened a pull request:

    https://github.com/apache/nifi/pull/2916

    NIFI-5451 Added test resources for 128 bit encryption.

    Fixed unit test to perform properly without JCE unlimited strength policy installed.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alopresto/nifi NIFI-5451

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2916
    
----
commit 8807423ef8196ff58590047512df5bd51f69b221
Author: Andy LoPresto <al...@...>
Date:   2018-07-25T00:13:59Z

    NIFI-5451 Added test resources for 128 bit encryption.
    Fixed unit test to perform properly without JCE unlimited strength policy installed.

----


> Modify NiFiGroovyTest.groovy to avoid needing unlimited strength JCE policy
> ---------------------------------------------------------------------------
>
>                 Key: NIFI-5451
>                 URL: https://issues.apache.org/jira/browse/NIFI-5451
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Michael Moser
>            Assignee: Andy LoPresto
>            Priority: Minor
>
> When running NiFiGroovyTest unit test when using a JDK that lacks unlimited strength JCE policy, the test fails.
>  
> [ERROR] testInitializePropertiesShouldSetBootstrapKeyFromFile(org.apache.nifi.NiFiGroovyTest)  Time elapsed: 0.121 s  <<< ERROR!
> java.lang.IllegalArgumentException: There was an issue decrypting protected properties
> at org.apache.nifi.NiFiGroovyTest.testInitializePropertiesShouldSetBootstrapKeyFromFile(NiFiGroovyTest.groovy:166)
> Caused by: org.apache.nifi.properties.SensitivePropertyProtectionException: The key must be a valid hexadecimal key
> at org.apache.nifi.NiFiGroovyTest.testInitializePropertiesShouldSetBootstrapKeyFromFile(NiFiGroovyTest.groovy:166)
>  
> The test uses a nifi.properties resource that does aes/gcm/256 encryption.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)