You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/04/19 08:40:59 UTC
[GitHub] [lucene] iverase opened a new pull request #94: LUCENE-9907: Remove unused methods in PackedInts
iverase opened a new pull request #94:
URL: https://github.com/apache/lucene/pull/94
PackedInts provides two ways to reader/write data, one using a header and writing the necessary metadata and a second option where there is not header or metadata and is up to the user to write such information.
We currently never use the option that writer harder and metadata in our codecs so lets remove it. In addition this PR removes the method `getDirectReaderNoHeader` as it is no used either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] iverase commented on a change in pull request #94: LUCENE-9907: Remove unused methods in PackedInts
Posted by GitBox <gi...@apache.org>.
iverase commented on a change in pull request #94:
URL: https://github.com/apache/lucene/pull/94#discussion_r615791876
##########
File path: lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java
##########
@@ -506,13 +504,13 @@ public void clear() {
}
/**
- * Save this mutable into <code>out</code>. Instantiating a reader from the generated data will
- * return a reader with the same number of bits per value.
+ * Save this mutable into <code>out</code>. This method does not write any metadata to the
+ * stream, meaning that it is your responsibility to store it somewhere else in order to be able
+ * to recover data from the stream later on.
*/
public void save(DataOutput out) throws IOException {
Review comment:
Yes, I will do it in a follow up PR. The issue is that removing this method affects `Packed64SingleBlock` which is a generated file and therefore we need to do stuff with the generation stuff to make precommit happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] iverase merged pull request #94: LUCENE-9907: Remove unused methods in PackedInts
Posted by GitBox <gi...@apache.org>.
iverase merged pull request #94:
URL: https://github.com/apache/lucene/pull/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on a change in pull request #94: LUCENE-9907: Remove unused methods in PackedInts
Posted by GitBox <gi...@apache.org>.
jpountz commented on a change in pull request #94:
URL: https://github.com/apache/lucene/pull/94#discussion_r615777238
##########
File path: lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java
##########
@@ -506,13 +504,13 @@ public void clear() {
}
/**
- * Save this mutable into <code>out</code>. Instantiating a reader from the generated data will
- * return a reader with the same number of bits per value.
+ * Save this mutable into <code>out</code>. This method does not write any metadata to the
+ * stream, meaning that it is your responsibility to store it somewhere else in order to be able
+ * to recover data from the stream later on.
*/
public void save(DataOutput out) throws IOException {
Review comment:
Should we remove this method too? It doesn't seem to be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org