[jira] [Commented] (FLINK-7850) Given each maven profile an activation property

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435694#comment-16435694 ] 

ASF GitHub Bot commented on FLINK-7850:
---------------------------------------

GitHub user kai-chi opened a pull request:

    https://github.com/apache/flink/pull/5840

    [FLINK-7850] [build system] Give each maven profile an activation property

    ## What is the purpose of the change
    
    This PR gives every maven profile an activation property so they can be activated with `-Dabcde`. This makes them a lot easier to work with in scripts that want to control profile activation, since you can just append `-D` switches.
    
    
    ## Brief change log
    
    Maven profiles that were missing activation property got one with the name equal to profile's name
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kai-chi/flink 7850

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5840.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5840
    
----

----


> Given each maven profile an activation property
> -----------------------------------------------
>
>                 Key: FLINK-7850
>                 URL: https://issues.apache.org/jira/browse/FLINK-7850
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Priority: Major
>              Labels: starter
>
> We should give every maven profile an activation property so that they can be activated with {{-Dabcde}}. This makes them a lot easier to work with in scripts that want to control profile activation, since you can just append {{-D}} switches. This doesn't work with the {{-P}} switch as it can only be specified once.
> {code}
> <activation>
> 	<property>
> 		<name>profile_name_or_something</name>
> 	</property>
> </activation>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)