You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2025/08/04 07:22:06 UTC
Re: [PR] [SPARK-53095][SQL] Support HMS v4.1 [spark]
LuciferYang commented on code in PR #51809:
URL: https://github.com/apache/spark/pull/51809#discussion_r2250626955
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala:
##########
@@ -336,7 +338,7 @@ class HiveClientSuite(version: String) extends HiveVersionSuite(version) {
}
test("listTables(database)") {
- assert(client.listTables("default") === Seq("src", "temporary", "view1"))
+ assert((client.listTables("default") diff Seq("src", "temporary", "view1")) === Nil)
Review Comment:
Why is a change needed here?
以上内容由文心人工智能生成
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala:
##########
@@ -336,7 +338,7 @@ class HiveClientSuite(version: String) extends HiveVersionSuite(version) {
}
test("listTables(database)") {
- assert(client.listTables("default") === Seq("src", "temporary", "view1"))
+ assert((client.listTables("default") diff Seq("src", "temporary", "view1")) === Nil)
Review Comment:
Why is a change needed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org