You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/10/22 08:05:38 UTC
[GitHub] [tomcat] dao-jun opened a new pull request #372: Update FileHandler.java
dao-jun opened a new pull request #372:
URL: https://github.com/apache/tomcat/pull/372
remove static keyword from `DELETE_FILES_SERVICE` to avoid class `ThreadPoolExecutor` loaded earlier than agent start.
It can cause agent enhance class `ThreadPoolExecutor` failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] dao-jun commented on pull request #372: Update FileHandler.java
Posted by GitBox <gi...@apache.org>.
dao-jun commented on pull request #372:
URL: https://github.com/apache/tomcat/pull/372#issuecomment-714342340
> The DELETE_FILES_SERVICE executor is intended to be a singleton. This PR breaks that and is, therefore, unlikely to be applied.
Yep, I forgot that. The pr will be closed and I would use inner class to keep the field singleton.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #372: Update FileHandler.java
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #372:
URL: https://github.com/apache/tomcat/pull/372#issuecomment-714333180
The DELETE_FILES_SERVICE executor is intended to be a singleton. This PR breaks that and is, therefore, unlikely to be applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] dao-jun closed pull request #372: Update FileHandler.java
Posted by GitBox <gi...@apache.org>.
dao-jun closed pull request #372:
URL: https://github.com/apache/tomcat/pull/372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org