[GitHub] [druid] cryptoe commented on a diff in pull request #12799: Add check for sqlOuterLimit to ingest queries

[GitBox <gi...@apache.org>]

cryptoe commented on code in PR #12799:
URL: https://github.com/apache/druid/pull/12799#discussion_r924034855


##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java:
##########
@@ -153,6 +153,9 @@ public ValidationResult validate(boolean authorizeContextParams) throws SqlParse
     final Set<ResourceAction> resourceActions = new HashSet<>(resourceCollectorShuttle.getResourceActions());
 
     if (parsed.getInsertOrReplace() != null) {
+      if (plannerContext.getQueryContext().get(PlannerContext.CTX_SQL_OUTER_LIMIT) != null) {

Review Comment:
   SuperNit: I would add a comment here explaining why it does not make sense for PlannerContext.CTX_SQL_OUTER_LIMIT to be part of Insert/Replace q. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org