You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2024/04/13 07:20:29 UTC

Re: [PR] arch/risc-v: fix RV32 addrenv destroy issue [nuttx]

xiaoxiang781216 commented on code in PR #12132:
URL: https://github.com/apache/nuttx/pull/12132#discussion_r1563827716


##########
arch/risc-v/src/common/riscv_addrenv.c:
##########
@@ -539,7 +539,11 @@ int up_addrenv_destroy(arch_addrenv_t *addrenv)
   ptprev = (uintptr_t *)riscv_pgvaddr(addrenv->spgtables[ARCH_SPGTS - 1]);
   if (ptprev)
     {
+  #ifndef CONFIG_ARCH_RV32

Review Comment:
   why CONFIG_ARCH_RV32 different from CONFIG_ARCH_RV64? should we unify 32/64bit code path?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org