You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/09 21:34:10 UTC

[GitHub] [pulsar] lifepuzzlefun commented on a diff in pull request #18073: [fix][txn] Port for master "Use PulsarClient HashWheelTimer to schedule producer batch trigger task"

lifepuzzlefun commented on code in PR #18073:
URL: https://github.com/apache/pulsar/pull/18073#discussion_r1044858261


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -159,7 +159,7 @@
     // The goal is to optimize batch density while also ensuring that a producer never waits longer than the configured
     // batchingMaxPublishDelayMicros to send a batch.
     // Only update from within synchronized block on this producer.
-    private ScheduledFuture<?> batchFlushTask;
+    private Timeout batchFlushTask;

Review Comment:
   @tisonkun thanks for review, this change not change the logic for when trigger the schecule task. just change the scheduler  to hashwheeltimer for better performance. maybe the comment can remain the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org