You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/16 18:53:23 UTC
[GitHub] [iceberg] rdblue opened a new pull request #1942: Add UpdatePartitionSpec operation for tables.
rdblue opened a new pull request #1942:
URL: https://github.com/apache/iceberg/pull/1942
This adds `UpdatePartitionSpec` to ` Table` and `Transaction`.
These changes are extracted from #922 and @jun-he is the primary author.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1942: Add UpdatePartitionSpec operation for tables.
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1942:
URL: https://github.com/apache/iceberg/pull/1942#issuecomment-746826772
@jun-he, I've extracted the partition spec update operation from #922 and added it on top of #1919. Most of these changes are yours, except I swapped out the API. There are also some additional changes in #922 that I didn't add because I wanted to keep this small. It would be great to have some of those refactors done, like updating tests to use the new API, if you are interested in contributing those changes in separate PRs or rebasing #922.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1942: Add UpdatePartitionSpec operation for tables.
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1942:
URL: https://github.com/apache/iceberg/pull/1942#issuecomment-746896078
Thanks for reviewing, @aokolnychyi!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1942: Add UpdatePartitionSpec operation for tables.
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1942:
URL: https://github.com/apache/iceberg/pull/1942#discussion_r544570662
##########
File path: core/src/test/java/org/apache/iceberg/TestTableMetadata.java
##########
@@ -501,7 +501,7 @@ public void testNewTableMetadataReassignmentAllIds() throws Exception {
PartitionSpec spec = PartitionSpec.builderFor(schema).withSpecId(5)
.add(3, 1005, "x_partition", "bucket[4]")
- .add(5, 1005, "z_partition", "bucket[8]")
+ .add(5, 1003, "z_partition", "bucket[8]")
Review comment:
The intent is to check whether the IDs are reassigned. The spec builder may reject duplicate IDs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1942: Add UpdatePartitionSpec operation for tables.
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1942:
URL: https://github.com/apache/iceberg/pull/1942#issuecomment-747042759
Thanks for reviewing, @aokolnychyi!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1942: Add UpdatePartitionSpec operation for tables.
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1942:
URL: https://github.com/apache/iceberg/pull/1942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1942: Add UpdatePartitionSpec operation for tables.
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #1942:
URL: https://github.com/apache/iceberg/pull/1942#discussion_r544548989
##########
File path: core/src/test/java/org/apache/iceberg/TestTableMetadata.java
##########
@@ -501,7 +501,7 @@ public void testNewTableMetadataReassignmentAllIds() throws Exception {
PartitionSpec spec = PartitionSpec.builderFor(schema).withSpecId(5)
.add(3, 1005, "x_partition", "bucket[4]")
- .add(5, 1005, "z_partition", "bucket[8]")
+ .add(5, 1003, "z_partition", "bucket[8]")
Review comment:
This was a typo before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org