You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by Jeremy Arnold <je...@bigfoot.com> on 2003/02/06 17:44:00 UTC
[PATCH] Throughput value not visible in Graph Visualizer
Hello,
The "Throughput" value in the Graph Visualizer (the numbers shown
beneath the graph) isn't always visible. The label shows up, but the
value does not. This probably depends on factors like screen
resolution, and also depends on the size of the JMeter window. But the
layout should be fixed so that it is always visible.
The problem is that the different labels and their values are
organized with a GridLayout, which divides the available space into
equal-sized areas. Within these areas, each label/value pair is laid
out with FlowLayout, which will wrap elements to a new row if they don't
all fit. Since the throughput value is longer than the others (it
displays "/minute" at the end of the value), the grid cells can be too
small, so the text field gets wrapped below the label, and this puts it
outside of the visible window area.
The fix for this is to use a different layout manager for these
components. I switched to a set of BoxLayouts, which won't wrap the
components, and organized the fields in rows and columns (more
BoxLayouts). In the process of doing this I made the layout of these
fields look more organized (in my opinion).
I also took this opportunity to refactor some of the repetitive code
in GraphVisualizer. Rather than doing all of the GUI construction in
init( ), I've spread it across private methods to create the different
subcomponents. I think this is much easier to read and modify.
If for some reason you don't like the refactoring I can send a patch
with just the bug fix and not these other changes.
This patch was generated from current CVS.
I'm going to be travelling over the next few days, so I may not be
able to respond immediately if there are any questions.
Thanks,
Jeremy