You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/27 13:59:38 UTC

[GitHub] [dubbo] wangchengming666 commented on a change in pull request #8925: [master] Fix remove duplicate method

wangchengming666 commented on a change in pull request #8925:
URL: https://github.com/apache/dubbo/pull/8925#discussion_r716720545



##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
##########
@@ -1266,8 +1264,6 @@ public void destroy() {
                         unexportServices();
                         unreferServices();
                     }
-
-                    destroyRegistries();

Review comment:
       因为`destroyRegistries()`这个方法中的静态方法在`DubboShutdownHook.destroyAll();`这个方法中重复调用了，所以需要删除，应该在`DubboShutdownHook.destroyAll();`来释放`register`和`protocols`。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org