You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/11/26 07:18:32 UTC
[GitHub] [incubator-brpc] guodongxiaren opened a new pull request, #2018: Support all compile options for Linux workflow
guodongxiaren opened a new pull request, #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
- Breaking backward compatibility(向后兼容性):
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #2018: Support all compile options and unittest for Linux workflow
Posted by GitBox <gi...@apache.org>.
zyearn commented on PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328098448
> 针对make编译，额外调用一次protoc来处理mcpack2pb中的proto，因为make的编译不稳定，经常报错src/mcpack2pb/generator.cpp:30:10: fatal error: idl_options.pb.h: No such file or directory
Side effects:
我记得这个是并发编译的时候protoc还在执行，但引用idl_options.pb.h已经需要前一步的结果了，这里应该需要加一个编译顺序
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on pull request #2018: Support all compile options and unittest for Linux workflow
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328227202
@zyearn 修改了，有空看下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #2018: Support all compile options and unittest for Linux workflow
Posted by GitBox <gi...@apache.org>.
zyearn commented on PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328318544
以及github主页上的build link应该要改成指向Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #2018: Support all compile options and unittest for Linux workflow
Posted by GitBox <gi...@apache.org>.
zyearn commented on PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328099489
install-all-dependences 和 install-dependences 的区别是all包含非必要的依赖，可以换个名字比如：
* install-essential-dependences
* install-all-dependences
然后all版本引用essential的文件而不是再写一份，不清楚这个在yml文件里能不能实现？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on pull request #2018: Support all compile options and unittest for Linux workflow
Posted by GitBox <gi...@apache.org>.
zyearn commented on PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328318092
赞，之后提个PR把老的travis删掉应该就好了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn merged pull request #2018: Support all compile options and unittest for Linux workflow
Posted by GitBox <gi...@apache.org>.
zyearn merged PR #2018:
URL: https://github.com/apache/incubator-brpc/pull/2018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org