You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/19 15:06:25 UTC
[GitHub] [hudi] YannByron opened a new pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
YannByron opened a new pull request #3823:
URL: https://github.com/apache/hudi/pull/3823
## What is the purpose of the pull request
We can specify different values to URL_ENCODE_PARTITIONING and HIVE_STYLE_PARTITIONING_ENABLE configs for multiple write operation without any warns or errors. And some partition path enable hive-style and some not, or some enable url-encode and some not, that is so weird.
So i wanna to persist these config to hoodie.properties when the first write (write data by spark dataframe the first time or create table by spark-sql). And then, uses do not need to specify these config any more. If these configs are specified and different to the existing value in hoodie.properties, exceptions will be raised.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-947514681
@leesf @vinothchandar can you help to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736724131
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -64,7 +67,7 @@ object HoodieSparkSqlWriter {
def write(sqlContext: SQLContext,
mode: SaveMode,
- parameters: Map[String, String],
+ optParams: Map[String, String],
Review comment:
It's needed. The `parameters` variable includes all default hoodie's parameters, and will be used as following codes. The `optParams` variable just used to validate whether there are conflicts between these and TableConfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-956197015
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008",
"triggerID" : "956197015",
"triggerType" : "MANUAL"
}, {
"hash" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014",
"triggerID" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"triggerType" : "PUSH"
}, {
"hash" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3017",
"triggerID" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3017)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c491ffdeda525930fe01333daa7de0aa9c691df1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r740244372
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala
##########
@@ -92,10 +92,9 @@ object HoodieWriterUtils {
* @return
*/
def getPartitionColumns(parameters: Map[String, String]): String = {
- val props = new TypedProperties()
+ val props = new Properties()
Review comment:
Because HoodieSparkUtils.getPartitionColumns use `Properties` the input parameter type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5474dc0794a59b677a11cbe2f4fe355ca18da041 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008",
"triggerID" : "956197015",
"triggerType" : "MANUAL"
}, {
"hash" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014",
"triggerID" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5474dc0794a59b677a11cbe2f4fe355ca18da041 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008)
* 6c8875db41107ad10112a5d7824f0e2c7548acc5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008",
"triggerID" : "956197015",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5474dc0794a59b677a11cbe2f4fe355ca18da041 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008",
"triggerID" : "956197015",
"triggerType" : "MANUAL"
}, {
"hash" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014",
"triggerID" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"triggerType" : "PUSH"
}, {
"hash" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3017",
"triggerID" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6c8875db41107ad10112a5d7824f0e2c7548acc5 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014)
* a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3017)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008",
"triggerID" : "956197015",
"triggerType" : "MANUAL"
}, {
"hash" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014",
"triggerID" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"triggerType" : "PUSH"
}, {
"hash" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3017",
"triggerID" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"triggerType" : "PUSH"
}, {
"hash" : "38d68b3add88e6cf7b81b4ae68029ad83ee54f29",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "38d68b3add88e6cf7b81b4ae68029ad83ee54f29",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3017)
* 38d68b3add88e6cf7b81b4ae68029ad83ee54f29 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf merged pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf merged pull request #3823:
URL: https://github.com/apache/hudi/pull/3823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736655928
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java
##########
@@ -51,44 +49,70 @@
private static final Logger LOG = LoggerFactory.getLogger(HoodieSparkKeyGeneratorFactory.class);
public static KeyGenerator createKeyGenerator(TypedProperties props) throws IOException {
- // keyGenerator class name has higher priority
- KeyGenerator keyGenerator = KeyGenUtils.createKeyGeneratorByClassName(props);
-
- return Objects.isNull(keyGenerator) ? createKeyGeneratorByType(props) : keyGenerator;
+ String keyGeneratorClass = getKeyGeneratorClassName(props);
+ try {
+ return (KeyGenerator) ReflectionUtils.loadClass(keyGeneratorClass, props);
+ } catch (Throwable e) {
+ throw new IOException("Could not load key generator class " + keyGeneratorClass, e);
+ }
}
- private static BuiltinKeyGenerator createKeyGeneratorByType(TypedProperties props) throws IOException {
- // Use KeyGeneratorType.SIMPLE as default keyGeneratorType
- String keyGeneratorType =
- props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE.key(), null);
+ public static String getKeyGeneratorClassName(TypedProperties props) {
+ String keyGeneratorClass = props.getString(HoodieWriteConfig.KEYGENERATOR_CLASS_NAME.key(), null);
- if (StringUtils.isNullOrEmpty(keyGeneratorType)) {
- LOG.info("The value of {} is empty, use SIMPLE", HoodieWriteConfig.KEYGENERATOR_TYPE.key());
- keyGeneratorType = KeyGeneratorType.SIMPLE.name();
+ if (StringUtils.isNullOrEmpty(keyGeneratorClass)) {
+ String keyGeneratorType = props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE.key(), KeyGeneratorType.SIMPLE.name());
Review comment:
can also move the LOG.info statement above to here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736670911
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -717,6 +719,16 @@ public PropertyBuilder setKeyGeneratorClassProp(String keyGeneratorClassProp) {
return this;
}
+ public PropertyBuilder setHiveStylePartitioningEnable(Boolean hiveStylePartitioningEnable) {
+ this.hiveStylePartitioningEnable = hiveStylePartitioningEnable;
Review comment:
should the add configs also handled in `UpgradeHandler` to handle hudi table version upgrade/downgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736664105
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -64,7 +67,7 @@ object HoodieSparkSqlWriter {
def write(sqlContext: SQLContext,
mode: SaveMode,
- parameters: Map[String, String],
+ optParams: Map[String, String],
Review comment:
no need to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 52aebe9b1f58192f9d53ab1d3ab94463775c52b9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736718500
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java
##########
@@ -51,44 +49,70 @@
private static final Logger LOG = LoggerFactory.getLogger(HoodieSparkKeyGeneratorFactory.class);
public static KeyGenerator createKeyGenerator(TypedProperties props) throws IOException {
- // keyGenerator class name has higher priority
- KeyGenerator keyGenerator = KeyGenUtils.createKeyGeneratorByClassName(props);
-
- return Objects.isNull(keyGenerator) ? createKeyGeneratorByType(props) : keyGenerator;
+ String keyGeneratorClass = getKeyGeneratorClassName(props);
+ try {
+ return (KeyGenerator) ReflectionUtils.loadClass(keyGeneratorClass, props);
+ } catch (Throwable e) {
+ throw new IOException("Could not load key generator class " + keyGeneratorClass, e);
+ }
}
- private static BuiltinKeyGenerator createKeyGeneratorByType(TypedProperties props) throws IOException {
- // Use KeyGeneratorType.SIMPLE as default keyGeneratorType
- String keyGeneratorType =
- props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE.key(), null);
+ public static String getKeyGeneratorClassName(TypedProperties props) {
+ String keyGeneratorClass = props.getString(HoodieWriteConfig.KEYGENERATOR_CLASS_NAME.key(), null);
- if (StringUtils.isNullOrEmpty(keyGeneratorType)) {
- LOG.info("The value of {} is empty, use SIMPLE", HoodieWriteConfig.KEYGENERATOR_TYPE.key());
- keyGeneratorType = KeyGeneratorType.SIMPLE.name();
+ if (StringUtils.isNullOrEmpty(keyGeneratorClass)) {
+ String keyGeneratorType = props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE.key(), KeyGeneratorType.SIMPLE.name());
+ KeyGeneratorType keyGeneratorTypeEnum;
+ try {
+ keyGeneratorTypeEnum = KeyGeneratorType.valueOf(keyGeneratorType.toUpperCase(Locale.ROOT));
+ } catch (IllegalArgumentException e) {
+ throw new HoodieKeyGeneratorException("Unsupported keyGenerator Type " + keyGeneratorType);
+ }
+ switch (keyGeneratorTypeEnum) {
+ case SIMPLE:
+ keyGeneratorClass = SimpleKeyGenerator.class.getName();
+ break;
+ case COMPLEX:
+ keyGeneratorClass = ComplexKeyGenerator.class.getName();
+ break;
+ case TIMESTAMP:
+ keyGeneratorClass = TimestampBasedKeyGenerator.class.getName();
+ break;
+ case CUSTOM:
+ keyGeneratorClass = CustomKeyGenerator.class.getName();
+ break;
+ case NON_PARTITION:
+ keyGeneratorClass = NonpartitionedKeyGenerator.class.getName();
+ break;
+ case GLOBAL_DELETE:
+ keyGeneratorClass = GlobalDeleteKeyGenerator.class.getName();
+ break;
+ default:
+ throw new HoodieKeyGeneratorException("Unsupported keyGenerator Type " + keyGeneratorType);
+ }
}
+ return keyGeneratorClass;
+ }
- KeyGeneratorType keyGeneratorTypeEnum;
- try {
- keyGeneratorTypeEnum = KeyGeneratorType.valueOf(keyGeneratorType.toUpperCase(Locale.ROOT));
- } catch (IllegalArgumentException e) {
- throw new HoodieKeyGeneratorException("Unsupported keyGenerator Type " + keyGeneratorType);
- }
- switch (keyGeneratorTypeEnum) {
- case SIMPLE:
- return new SimpleKeyGenerator(props);
- case COMPLEX:
- return new ComplexKeyGenerator(props);
- case TIMESTAMP:
- return new TimestampBasedKeyGenerator(props);
- case CUSTOM:
- return new CustomKeyGenerator(props);
- case NON_PARTITION:
- return new NonpartitionedKeyGenerator(props);
- case GLOBAL_DELETE:
- return new GlobalDeleteKeyGenerator(props);
+ /**
+ * Convert hoodie-common KeyGenerator to SparkKeyGeneratorInterface implement.
+ */
+ public static String convertToSparkKeyGenerator(String keyGeneratorClassName) {
+ switch (keyGeneratorClassName) {
+ case "org.apache.hudi.keygen.ComplexAvroKeyGenerator":
+ return "org.apache.hudi.keygen.ComplexKeyGenerator";
Review comment:
KenGenerators whose name isn't include 'Avro' extends SparkKeyGeneratorInterface which has method `getRecordKey` and `getPartitionPath` from Row. I wanna to make sure the KeyGenerator's instance works within Spark via `convertToSparkKeyGenerator `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736720713
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestCustomKeyGenerator.java
##########
@@ -259,7 +268,7 @@ public void testNoRecordKeyFieldProp(boolean useKeyGeneratorClassName) {
.getMessage()
.contains("Property hoodie.datasource.write.recordkey.field not found"));
} else {
- Assertions.assertTrue(e.getMessage().contains("Property hoodie.datasource.write.recordkey.field not found"));
Review comment:
I refactor the method `createKeyGenerator` which wouldn't throw an exception with this message directly, but this message "Property hoodie.datasource.write.recordkey.field not found" exists in the exception's stacktrace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5474dc0794a59b677a11cbe2f4fe355ca18da041 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008",
"triggerID" : "956197015",
"triggerType" : "MANUAL"
}, {
"hash" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5474dc0794a59b677a11cbe2f4fe355ca18da041 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008)
* 6c8875db41107ad10112a5d7824f0e2c7548acc5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736729813
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -74,16 +77,23 @@ object HoodieSparkSqlWriter {
: (Boolean, common.util.Option[String], common.util.Option[String], common.util.Option[String],
SparkRDDWriteClient[HoodieRecordPayload[Nothing]], HoodieTableConfig) = {
+ assert(optParams.get("path").exists(!StringUtils.isNullOrEmpty(_)), "'path' must be set")
+ val path = optParams("path")
+ val basePath = new Path(path)
val sparkContext = sqlContext.sparkContext
- val path = parameters.get("path")
- val hoodieConfig = HoodieWriterUtils.convertMapToHoodieConfig(parameters)
- val tblNameOp = hoodieConfig.getStringOrThrow(HoodieWriteConfig.TBL_NAME, s"'${HoodieWriteConfig.TBL_NAME.key}' must be set.")
+ val fs = basePath.getFileSystem(sparkContext.hadoopConfiguration)
+ tableExists = fs.exists(new Path(basePath, HoodieTableMetaClient.METAFOLDER_NAME))
+ var tableConfig = getHoodieTableConfig(sparkContext, path, hoodieTableConfigOpt)
+ validateTableConfig(sqlContext.sparkSession, optParams, tableConfig)
+
+ val parameters = DataSourceWriteOptions.translateSqlOptions(HoodieWriterUtils.parametersWithWriteDefaults(optParams))
+ val hoodieConfig = mergeAndGetHoodieConfig(parameters, tableConfig)
+ assert(!StringUtils.isNullOrEmpty(hoodieConfig.getString(HoodieWriteConfig.TBL_NAME)),
Review comment:
agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 704b6441521e368672d45893fa951fbd22257fa5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877)
* 5a7a29fde2567f91ed3deea36825f84427aa4634 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8441914c4ba8d117ea0b85972f6f2d89f018f231 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907)
* 56158e909c326d687b0e5f84201649807e3edff1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r740244372
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala
##########
@@ -92,10 +92,9 @@ object HoodieWriterUtils {
* @return
*/
def getPartitionColumns(parameters: Map[String, String]): String = {
- val props = new TypedProperties()
+ val props = new Properties()
Review comment:
Because HoodieSparkUtils.getPartitionColumns use `Properties` as the input parameter type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-955950015
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 52aebe9b1f58192f9d53ab1d3ab94463775c52b9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf merged pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf merged pull request #3823:
URL: https://github.com/apache/hudi/pull/3823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a7a29fde2567f91ed3deea36825f84427aa4634 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c44ff493766fdc192dca76d31299da512c83854f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881)
* 6a482ae52b1b94bb1136f5f29eb34e1ae421b087 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889)
* 791e31216680da7787fba48c0c8347e6d00f02bf UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ce2404609630fc4718cd3d021c895cb3aeb49b4 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738)
* c491ffdeda525930fe01333daa7de0aa9c691df1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736728472
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java
##########
@@ -51,44 +49,70 @@
private static final Logger LOG = LoggerFactory.getLogger(HoodieSparkKeyGeneratorFactory.class);
public static KeyGenerator createKeyGenerator(TypedProperties props) throws IOException {
- // keyGenerator class name has higher priority
- KeyGenerator keyGenerator = KeyGenUtils.createKeyGeneratorByClassName(props);
-
- return Objects.isNull(keyGenerator) ? createKeyGeneratorByType(props) : keyGenerator;
+ String keyGeneratorClass = getKeyGeneratorClassName(props);
+ try {
+ return (KeyGenerator) ReflectionUtils.loadClass(keyGeneratorClass, props);
+ } catch (Throwable e) {
+ throw new IOException("Could not load key generator class " + keyGeneratorClass, e);
+ }
}
- private static BuiltinKeyGenerator createKeyGeneratorByType(TypedProperties props) throws IOException {
- // Use KeyGeneratorType.SIMPLE as default keyGeneratorType
- String keyGeneratorType =
- props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE.key(), null);
+ public static String getKeyGeneratorClassName(TypedProperties props) {
+ String keyGeneratorClass = props.getString(HoodieWriteConfig.KEYGENERATOR_CLASS_NAME.key(), null);
- if (StringUtils.isNullOrEmpty(keyGeneratorType)) {
- LOG.info("The value of {} is empty, use SIMPLE", HoodieWriteConfig.KEYGENERATOR_TYPE.key());
- keyGeneratorType = KeyGeneratorType.SIMPLE.name();
+ if (StringUtils.isNullOrEmpty(keyGeneratorClass)) {
+ String keyGeneratorType = props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE.key(), KeyGeneratorType.SIMPLE.name());
Review comment:
ok, i'll do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 791e31216680da7787fba48c0c8347e6d00f02bf Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894)
* 8441914c4ba8d117ea0b85972f6f2d89f018f231 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 52aebe9b1f58192f9d53ab1d3ab94463775c52b9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a7a29fde2567f91ed3deea36825f84427aa4634 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879)
* c44ff493766fdc192dca76d31299da512c83854f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a7a29fde2567f91ed3deea36825f84427aa4634 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879)
* c44ff493766fdc192dca76d31299da512c83854f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c44ff493766fdc192dca76d31299da512c83854f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8441914c4ba8d117ea0b85972f6f2d89f018f231 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907)
* 56158e909c326d687b0e5f84201649807e3edff1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008",
"triggerID" : "956197015",
"triggerType" : "MANUAL"
}, {
"hash" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014",
"triggerID" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"triggerType" : "PUSH"
}, {
"hash" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3017",
"triggerID" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"triggerType" : "PUSH"
}, {
"hash" : "38d68b3add88e6cf7b81b4ae68029ad83ee54f29",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3060",
"triggerID" : "38d68b3add88e6cf7b81b4ae68029ad83ee54f29",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 38d68b3add88e6cf7b81b4ae68029ad83ee54f29 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3060)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008",
"triggerID" : "956197015",
"triggerType" : "MANUAL"
}, {
"hash" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014",
"triggerID" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"triggerType" : "PUSH"
}, {
"hash" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5474dc0794a59b677a11cbe2f4fe355ca18da041 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008)
* 6c8875db41107ad10112a5d7824f0e2c7548acc5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014)
* a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 52aebe9b1f58192f9d53ab1d3ab94463775c52b9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720)
* 5ce2404609630fc4718cd3d021c895cb3aeb49b4 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56158e909c326d687b0e5f84201649807e3edff1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937)
* 5474dc0794a59b677a11cbe2f4fe355ca18da041 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r740215442
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
##########
@@ -34,9 +35,9 @@ import org.apache.spark.sql.hudi.command.payload.ExpressionPayload
import org.apache.spark.sql.hudi.command.payload.ExpressionPayload._
import org.apache.spark.sql.hudi.{HoodieOptionConfig, SerDeUtils}
import org.apache.spark.sql.types.{BooleanType, StructType}
-
import java.util.Base64
+
Review comment:
no need to add the empty line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008",
"triggerID" : "956197015",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5474dc0794a59b677a11cbe2f4fe355ca18da041 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008",
"triggerID" : "956197015",
"triggerType" : "MANUAL"
}, {
"hash" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014",
"triggerID" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"triggerType" : "PUSH"
}, {
"hash" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6c8875db41107ad10112a5d7824f0e2c7548acc5 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014)
* a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736728141
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -717,6 +719,16 @@ public PropertyBuilder setKeyGeneratorClassProp(String keyGeneratorClassProp) {
return this;
}
+ public PropertyBuilder setHiveStylePartitioningEnable(Boolean hiveStylePartitioningEnable) {
+ this.hiveStylePartitioningEnable = hiveStylePartitioningEnable;
Review comment:
Thanks for reminding me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56158e909c326d687b0e5f84201649807e3edff1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5474dc0794a59b677a11cbe2f4fe355ca18da041 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] YannByron commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
YannByron commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r740242788
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
##########
@@ -34,9 +35,9 @@ import org.apache.spark.sql.hudi.command.payload.ExpressionPayload
import org.apache.spark.sql.hudi.command.payload.ExpressionPayload._
import org.apache.spark.sql.hudi.{HoodieOptionConfig, SerDeUtils}
import org.apache.spark.sql.types.{BooleanType, StructType}
-
import java.util.Base64
+
Review comment:
i'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf merged pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf merged pull request #3823:
URL: https://github.com/apache/hudi/pull/3823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a482ae52b1b94bb1136f5f29eb34e1ae421b087 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889)
* 791e31216680da7787fba48c0c8347e6d00f02bf Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 791e31216680da7787fba48c0c8347e6d00f02bf Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c44ff493766fdc192dca76d31299da512c83854f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881)
* 6a482ae52b1b94bb1136f5f29eb34e1ae421b087 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c44ff493766fdc192dca76d31299da512c83854f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881)
* 6a482ae52b1b94bb1136f5f29eb34e1ae421b087 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736665214
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -74,16 +77,23 @@ object HoodieSparkSqlWriter {
: (Boolean, common.util.Option[String], common.util.Option[String], common.util.Option[String],
SparkRDDWriteClient[HoodieRecordPayload[Nothing]], HoodieTableConfig) = {
+ assert(optParams.get("path").exists(!StringUtils.isNullOrEmpty(_)), "'path' must be set")
+ val path = optParams("path")
+ val basePath = new Path(path)
val sparkContext = sqlContext.sparkContext
- val path = parameters.get("path")
- val hoodieConfig = HoodieWriterUtils.convertMapToHoodieConfig(parameters)
- val tblNameOp = hoodieConfig.getStringOrThrow(HoodieWriteConfig.TBL_NAME, s"'${HoodieWriteConfig.TBL_NAME.key}' must be set.")
+ val fs = basePath.getFileSystem(sparkContext.hadoopConfiguration)
+ tableExists = fs.exists(new Path(basePath, HoodieTableMetaClient.METAFOLDER_NAME))
+ var tableConfig = getHoodieTableConfig(sparkContext, path, hoodieTableConfigOpt)
+ validateTableConfig(sqlContext.sparkSession, optParams, tableConfig)
+
+ val parameters = DataSourceWriteOptions.translateSqlOptions(HoodieWriterUtils.parametersWithWriteDefaults(optParams))
+ val hoodieConfig = mergeAndGetHoodieConfig(parameters, tableConfig)
+ assert(!StringUtils.isNullOrEmpty(hoodieConfig.getString(HoodieWriteConfig.TBL_NAME)),
Review comment:
`hoodieConfig.getStringOrThrow` before is good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 52aebe9b1f58192f9d53ab1d3ab94463775c52b9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720)
* 5ce2404609630fc4718cd3d021c895cb3aeb49b4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736658212
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java
##########
@@ -51,44 +49,70 @@
private static final Logger LOG = LoggerFactory.getLogger(HoodieSparkKeyGeneratorFactory.class);
public static KeyGenerator createKeyGenerator(TypedProperties props) throws IOException {
- // keyGenerator class name has higher priority
- KeyGenerator keyGenerator = KeyGenUtils.createKeyGeneratorByClassName(props);
-
- return Objects.isNull(keyGenerator) ? createKeyGeneratorByType(props) : keyGenerator;
+ String keyGeneratorClass = getKeyGeneratorClassName(props);
+ try {
+ return (KeyGenerator) ReflectionUtils.loadClass(keyGeneratorClass, props);
+ } catch (Throwable e) {
+ throw new IOException("Could not load key generator class " + keyGeneratorClass, e);
+ }
}
- private static BuiltinKeyGenerator createKeyGeneratorByType(TypedProperties props) throws IOException {
- // Use KeyGeneratorType.SIMPLE as default keyGeneratorType
- String keyGeneratorType =
- props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE.key(), null);
+ public static String getKeyGeneratorClassName(TypedProperties props) {
+ String keyGeneratorClass = props.getString(HoodieWriteConfig.KEYGENERATOR_CLASS_NAME.key(), null);
- if (StringUtils.isNullOrEmpty(keyGeneratorType)) {
- LOG.info("The value of {} is empty, use SIMPLE", HoodieWriteConfig.KEYGENERATOR_TYPE.key());
- keyGeneratorType = KeyGeneratorType.SIMPLE.name();
+ if (StringUtils.isNullOrEmpty(keyGeneratorClass)) {
+ String keyGeneratorType = props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE.key(), KeyGeneratorType.SIMPLE.name());
+ KeyGeneratorType keyGeneratorTypeEnum;
+ try {
+ keyGeneratorTypeEnum = KeyGeneratorType.valueOf(keyGeneratorType.toUpperCase(Locale.ROOT));
+ } catch (IllegalArgumentException e) {
+ throw new HoodieKeyGeneratorException("Unsupported keyGenerator Type " + keyGeneratorType);
+ }
+ switch (keyGeneratorTypeEnum) {
+ case SIMPLE:
+ keyGeneratorClass = SimpleKeyGenerator.class.getName();
+ break;
+ case COMPLEX:
+ keyGeneratorClass = ComplexKeyGenerator.class.getName();
+ break;
+ case TIMESTAMP:
+ keyGeneratorClass = TimestampBasedKeyGenerator.class.getName();
+ break;
+ case CUSTOM:
+ keyGeneratorClass = CustomKeyGenerator.class.getName();
+ break;
+ case NON_PARTITION:
+ keyGeneratorClass = NonpartitionedKeyGenerator.class.getName();
+ break;
+ case GLOBAL_DELETE:
+ keyGeneratorClass = GlobalDeleteKeyGenerator.class.getName();
+ break;
+ default:
+ throw new HoodieKeyGeneratorException("Unsupported keyGenerator Type " + keyGeneratorType);
+ }
}
+ return keyGeneratorClass;
+ }
- KeyGeneratorType keyGeneratorTypeEnum;
- try {
- keyGeneratorTypeEnum = KeyGeneratorType.valueOf(keyGeneratorType.toUpperCase(Locale.ROOT));
- } catch (IllegalArgumentException e) {
- throw new HoodieKeyGeneratorException("Unsupported keyGenerator Type " + keyGeneratorType);
- }
- switch (keyGeneratorTypeEnum) {
- case SIMPLE:
- return new SimpleKeyGenerator(props);
- case COMPLEX:
- return new ComplexKeyGenerator(props);
- case TIMESTAMP:
- return new TimestampBasedKeyGenerator(props);
- case CUSTOM:
- return new CustomKeyGenerator(props);
- case NON_PARTITION:
- return new NonpartitionedKeyGenerator(props);
- case GLOBAL_DELETE:
- return new GlobalDeleteKeyGenerator(props);
+ /**
+ * Convert hoodie-common KeyGenerator to SparkKeyGeneratorInterface implement.
+ */
+ public static String convertToSparkKeyGenerator(String keyGeneratorClassName) {
+ switch (keyGeneratorClassName) {
+ case "org.apache.hudi.keygen.ComplexAvroKeyGenerator":
+ return "org.apache.hudi.keygen.ComplexKeyGenerator";
Review comment:
what's the difference between `case "org.apache.hudi.keygen.ComplexAvroKeyGenerator":
return "org.apache.hudi.keygen.ComplexKeyGenerator";` I would not get the point here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 791e31216680da7787fba48c0c8347e6d00f02bf Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894)
* 8441914c4ba8d117ea0b85972f6f2d89f018f231 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r740213590
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala
##########
@@ -92,10 +92,9 @@ object HoodieWriterUtils {
* @return
*/
def getPartitionColumns(parameters: Map[String, String]): String = {
- val props = new TypedProperties()
+ val props = new Properties()
Review comment:
why need this change, TypedProperties should act as same as Properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56158e909c326d687b0e5f84201649807e3edff1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937)
* 5474dc0794a59b677a11cbe2f4fe355ca18da041 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 704b6441521e368672d45893fa951fbd22257fa5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877)
* 5a7a29fde2567f91ed3deea36825f84427aa4634 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a482ae52b1b94bb1136f5f29eb34e1ae421b087 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889)
* 791e31216680da7787fba48c0c8347e6d00f02bf UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8441914c4ba8d117ea0b85972f6f2d89f018f231 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ce2404609630fc4718cd3d021c895cb3aeb49b4 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ce2404609630fc4718cd3d021c895cb3aeb49b4 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738)
* c491ffdeda525930fe01333daa7de0aa9c691df1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736658212
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java
##########
@@ -51,44 +49,70 @@
private static final Logger LOG = LoggerFactory.getLogger(HoodieSparkKeyGeneratorFactory.class);
public static KeyGenerator createKeyGenerator(TypedProperties props) throws IOException {
- // keyGenerator class name has higher priority
- KeyGenerator keyGenerator = KeyGenUtils.createKeyGeneratorByClassName(props);
-
- return Objects.isNull(keyGenerator) ? createKeyGeneratorByType(props) : keyGenerator;
+ String keyGeneratorClass = getKeyGeneratorClassName(props);
+ try {
+ return (KeyGenerator) ReflectionUtils.loadClass(keyGeneratorClass, props);
+ } catch (Throwable e) {
+ throw new IOException("Could not load key generator class " + keyGeneratorClass, e);
+ }
}
- private static BuiltinKeyGenerator createKeyGeneratorByType(TypedProperties props) throws IOException {
- // Use KeyGeneratorType.SIMPLE as default keyGeneratorType
- String keyGeneratorType =
- props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE.key(), null);
+ public static String getKeyGeneratorClassName(TypedProperties props) {
+ String keyGeneratorClass = props.getString(HoodieWriteConfig.KEYGENERATOR_CLASS_NAME.key(), null);
- if (StringUtils.isNullOrEmpty(keyGeneratorType)) {
- LOG.info("The value of {} is empty, use SIMPLE", HoodieWriteConfig.KEYGENERATOR_TYPE.key());
- keyGeneratorType = KeyGeneratorType.SIMPLE.name();
+ if (StringUtils.isNullOrEmpty(keyGeneratorClass)) {
+ String keyGeneratorType = props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE.key(), KeyGeneratorType.SIMPLE.name());
+ KeyGeneratorType keyGeneratorTypeEnum;
+ try {
+ keyGeneratorTypeEnum = KeyGeneratorType.valueOf(keyGeneratorType.toUpperCase(Locale.ROOT));
+ } catch (IllegalArgumentException e) {
+ throw new HoodieKeyGeneratorException("Unsupported keyGenerator Type " + keyGeneratorType);
+ }
+ switch (keyGeneratorTypeEnum) {
+ case SIMPLE:
+ keyGeneratorClass = SimpleKeyGenerator.class.getName();
+ break;
+ case COMPLEX:
+ keyGeneratorClass = ComplexKeyGenerator.class.getName();
+ break;
+ case TIMESTAMP:
+ keyGeneratorClass = TimestampBasedKeyGenerator.class.getName();
+ break;
+ case CUSTOM:
+ keyGeneratorClass = CustomKeyGenerator.class.getName();
+ break;
+ case NON_PARTITION:
+ keyGeneratorClass = NonpartitionedKeyGenerator.class.getName();
+ break;
+ case GLOBAL_DELETE:
+ keyGeneratorClass = GlobalDeleteKeyGenerator.class.getName();
+ break;
+ default:
+ throw new HoodieKeyGeneratorException("Unsupported keyGenerator Type " + keyGeneratorType);
+ }
}
+ return keyGeneratorClass;
+ }
- KeyGeneratorType keyGeneratorTypeEnum;
- try {
- keyGeneratorTypeEnum = KeyGeneratorType.valueOf(keyGeneratorType.toUpperCase(Locale.ROOT));
- } catch (IllegalArgumentException e) {
- throw new HoodieKeyGeneratorException("Unsupported keyGenerator Type " + keyGeneratorType);
- }
- switch (keyGeneratorTypeEnum) {
- case SIMPLE:
- return new SimpleKeyGenerator(props);
- case COMPLEX:
- return new ComplexKeyGenerator(props);
- case TIMESTAMP:
- return new TimestampBasedKeyGenerator(props);
- case CUSTOM:
- return new CustomKeyGenerator(props);
- case NON_PARTITION:
- return new NonpartitionedKeyGenerator(props);
- case GLOBAL_DELETE:
- return new GlobalDeleteKeyGenerator(props);
+ /**
+ * Convert hoodie-common KeyGenerator to SparkKeyGeneratorInterface implement.
+ */
+ public static String convertToSparkKeyGenerator(String keyGeneratorClassName) {
+ switch (keyGeneratorClassName) {
+ case "org.apache.hudi.keygen.ComplexAvroKeyGenerator":
+ return "org.apache.hudi.keygen.ComplexKeyGenerator";
Review comment:
what's the difference between `case "org.apache.hudi.keygen.ComplexAvroKeyGenerator":
return "org.apache.hudi.keygen.ComplexKeyGenerator";`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#discussion_r736660076
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestCustomKeyGenerator.java
##########
@@ -259,7 +268,7 @@ public void testNoRecordKeyFieldProp(boolean useKeyGeneratorClassName) {
.getMessage()
.contains("Property hoodie.datasource.write.recordkey.field not found"));
} else {
- Assertions.assertTrue(e.getMessage().contains("Property hoodie.datasource.write.recordkey.field not found"));
Review comment:
why need the change here?
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestCustomKeyGenerator.java
##########
@@ -282,7 +291,7 @@ public void testNoRecordKeyFieldProp(boolean useKeyGeneratorClassName) {
.getMessage()
.contains("Property hoodie.datasource.write.recordkey.field not found"));
} else {
- Assertions.assertTrue(e.getMessage().contains("Property hoodie.datasource.write.recordkey.field not found"));
+ Assertions.assertTrue(stackTraceToString(e).contains("Property hoodie.datasource.write.recordkey.field not found"));
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
}, {
"hash" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2879",
"triggerID" : "5a7a29fde2567f91ed3deea36825f84427aa4634",
"triggerType" : "PUSH"
}, {
"hash" : "c44ff493766fdc192dca76d31299da512c83854f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2881",
"triggerID" : "c44ff493766fdc192dca76d31299da512c83854f",
"triggerType" : "PUSH"
}, {
"hash" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2889",
"triggerID" : "6a482ae52b1b94bb1136f5f29eb34e1ae421b087",
"triggerType" : "PUSH"
}, {
"hash" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2894",
"triggerID" : "791e31216680da7787fba48c0c8347e6d00f02bf",
"triggerType" : "PUSH"
}, {
"hash" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2907",
"triggerID" : "8441914c4ba8d117ea0b85972f6f2d89f018f231",
"triggerType" : "PUSH"
}, {
"hash" : "56158e909c326d687b0e5f84201649807e3edff1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2937",
"triggerID" : "56158e909c326d687b0e5f84201649807e3edff1",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2999",
"triggerID" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"triggerType" : "PUSH"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3001",
"triggerID" : "955950015",
"triggerType" : "MANUAL"
}, {
"hash" : "5474dc0794a59b677a11cbe2f4fe355ca18da041",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3008",
"triggerID" : "956197015",
"triggerType" : "MANUAL"
}, {
"hash" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3014",
"triggerID" : "6c8875db41107ad10112a5d7824f0e2c7548acc5",
"triggerType" : "PUSH"
}, {
"hash" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3017",
"triggerID" : "a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a",
"triggerType" : "PUSH"
}, {
"hash" : "38d68b3add88e6cf7b81b4ae68029ad83ee54f29",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3060",
"triggerID" : "38d68b3add88e6cf7b81b4ae68029ad83ee54f29",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a9673c00eeb75c7ac5cc709e14b9f6ecf2c5ea2a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3017)
* 38d68b3add88e6cf7b81b4ae68029ad83ee54f29 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3060)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c491ffdeda525930fe01333daa7de0aa9c691df1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857)
* 704b6441521e368672d45893fa951fbd22257fa5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 704b6441521e368672d45893fa951fbd22257fa5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2877)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3823:
URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2720",
"triggerID" : "52aebe9b1f58192f9d53ab1d3ab94463775c52b9",
"triggerType" : "PUSH"
}, {
"hash" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2738",
"triggerID" : "5ce2404609630fc4718cd3d021c895cb3aeb49b4",
"triggerType" : "PUSH"
}, {
"hash" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857",
"triggerID" : "c491ffdeda525930fe01333daa7de0aa9c691df1",
"triggerType" : "PUSH"
}, {
"hash" : "704b6441521e368672d45893fa951fbd22257fa5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "704b6441521e368672d45893fa951fbd22257fa5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c491ffdeda525930fe01333daa7de0aa9c691df1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2857)
* 704b6441521e368672d45893fa951fbd22257fa5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org