You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arwin Arni <ar...@collab.net> on 2011/05/18 15:15:02 UTC

[PATCH] Add XFail test case for Issue 3867

Hi All,

I have attached a test case for Issue 3867 
(http://subversion.tigris.org/issues/show_bug.cgi?id=3867)

Issue Summary:
reintegrate merges create mergeinfo for non-existent paths

Regards,
Arwin Arni

Re: [PATCH] Add XFail test case for Issue 3867

Posted by Arwin Arni <ar...@collab.net>.
On Wednesday 18 May 2011 08:03 PM, Paul Burba wrote:
> On Wed, May 18, 2011 at 9:15 AM, Arwin Arni<ar...@collab.net>  wrote:
>> Hi All,
>>
>> I have attached a test case for Issue 3867
>> (http://subversion.tigris.org/issues/show_bug.cgi?id=3867)
>>
>> Issue Summary:
>> reintegrate merges create mergeinfo for non-existent paths
>>
>> Regards,
>> Arwin Arni
> Thanks Arwin.  I committed your test in r1124283.  I made a few minor
> tweaks to it:
>
> 1) Removed some of the pre-branching "trunk" edits, since one or two
> is sufficient to demonstrate the bug.
>
> 2) Removed the additional "trunk" edits after you made the branch,
> since these aren't relevant to the issue.  Instead I made a single
> edit on the "branch" and then synced the "branch" with "trunk", so we
> are following the common use case of reintegrate.
>
> 3) Added some short informative log messages to the text edit commits
> rather than simply "m".
>
> 4) In the log message I added this leading line:
>
> "Add a test for issue #3867 'reintegrate merges create mergeinfo for
> non-existent paths'"
>
> I find it useful to have the summary of the issue spelled out in the
> log message.  This helps the log message stand on it's own a bit
> better (for those of use who haven't memorized all of the issue
> numbers :-)
>
> Paul
Thanks Paul, and sorry about that slipshod patch. I know it could've 
been cleaner.

Regards,
Arwin Arni

Re: [PATCH] Add XFail test case for Issue 3867

Posted by Paul Burba <pt...@gmail.com>.
On Wed, May 18, 2011 at 9:15 AM, Arwin Arni <ar...@collab.net> wrote:
> Hi All,
>
> I have attached a test case for Issue 3867
> (http://subversion.tigris.org/issues/show_bug.cgi?id=3867)
>
> Issue Summary:
> reintegrate merges create mergeinfo for non-existent paths
>
> Regards,
> Arwin Arni

Thanks Arwin.  I committed your test in r1124283.  I made a few minor
tweaks to it:

1) Removed some of the pre-branching "trunk" edits, since one or two
is sufficient to demonstrate the bug.

2) Removed the additional "trunk" edits after you made the branch,
since these aren't relevant to the issue.  Instead I made a single
edit on the "branch" and then synced the "branch" with "trunk", so we
are following the common use case of reintegrate.

3) Added some short informative log messages to the text edit commits
rather than simply "m".

4) In the log message I added this leading line:

"Add a test for issue #3867 'reintegrate merges create mergeinfo for
non-existent paths'"

I find it useful to have the summary of the issue spelled out in the
log message.  This helps the log message stand on it's own a bit
better (for those of use who haven't memorized all of the issue
numbers :-)

Paul