You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/02/03 15:26:34 UTC

[GitHub] [hudi] wangxianghu commented on a change in pull request #2526: [HUDI-1420] HoodieTableMetaClient.getMarkerFolderPath works incorrectly on windows client with hdfs server for wrong file seperator

wangxianghu commented on a change in pull request #2526:
URL: https://github.com/apache/hudi/pull/2526#discussion_r569505718



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -118,7 +120,7 @@ public HoodieTableMetaClient(Configuration conf, String basePath, boolean loadAc
                                ConsistencyGuardConfig consistencyGuardConfig, Option<TimelineLayoutVersion> layoutVersion,
                                String payloadClassName) {
     LOG.info("Loading HoodieTableMetaClient from " + basePath);
-    this.basePath = basePath;
+    this.basePath = FilenameUtils.separatorsToUnix(basePath);

Review comment:
       This change seems unnecessary， WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org