[GitHub] [flink-docker] patricklucas commented on issue #5: [FLINK-15831] Improve documentation in README.md

[GitBox <gi...@apache.org>]

patricklucas commented on issue #5: [FLINK-15831] Improve documentation in README.md
URL: https://github.com/apache/flink-docker/pull/5#issuecomment-583331151
 
 
   > LGTM overall. I ran the scripts for a fake 1.10 release as described and the generated output looks good (see [my fork](https://github.com/uce/flink-docker/tree/flink_15831)). Easy to follow process. 👍
   > 
   > For `generate-stackbrew-library.sh` I noticed two things that we may want to address either as part of this PR or in a follow up:
   > 
   > ```shell
   > declare -A aliases=(
   >     [1.9]='latest'
   > )
   > ```
   > 
   > Do we want to add a note that this needs to be updated if a new version is added? We can also add logic to figure out the latest version automatically later.
   > 
   > The call
   > 
   > ```shell
   > versions=( ?.?/ )
   > ```
   > 
   > does not recognize `1.10` and therefore does not generate any output for 1.10.
   
   Good point and nice catch. Maybe for now I'll add separate sections for new Flink minor release and new Flink patch release.
   
   I'd love to just rewrite this in Python or something, using Bash for some of this logic is fairly painful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services