[PATCH] Rename "--git-diff" to "--git" for "svn diff"

[anatoly techtonik <te...@gmail.com>]

Here is the patch. I've embedded log message inside and also opened
Rietveld issue if you like. http://codereview.appspot.com/2012048/
--
anatoly t.



On Wed, Aug 25, 2010 at 12:21 PM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> Stefan Sperling wrote on Tue, Aug 24, 2010 at 23:03:24 +0200:
>> On Tue, Aug 24, 2010 at 07:51:28PM +0300, anatoly techtonik wrote:
>> > Good to know. Is it worth to rename it to `svn diff --git` for
>> > unification with Mercurial?
>>
>> I suppose we could rename the option to "--git", yes.
>> Do you want to send a patch that does so?
>
> If yes, make sure to update all the tests too...
>
>> See http://subversion.apache.org/docs/community-guide/general.html#patches
>>
>> Thanks,
>> Stefan
>

Re: [PATCH] Rename "--git-diff" to "--git" for "svn diff"

[anatoly techtonik <te...@gmail.com>]

On Wed, Aug 25, 2010 at 10:58 PM, Stefan Sperling <st...@elego.de> wrote:
>> Here is the patch. I've embedded log message inside and also opened
>> Rietveld issue if you like. http://codereview.appspot.com/2012048/
>
> Thank you! Committed in r989327.
>
> I've tweaked the log message a bit, most importanly to mention
> the symbol names of things that have changed, which we usually
> do in our log messages so that it's easy to find changes made
> to a specific struct or function.

Thanks. Now I see how it should look like.
--
anatoly t.

Re: [PATCH] Rename "--git-diff" to "--git" for "svn diff"

[Stefan Sperling <st...@elego.de>]

On Wed, Aug 25, 2010 at 07:13:15PM +0300, anatoly techtonik wrote:
> Here is the patch. I've embedded log message inside and also opened
> Rietveld issue if you like. http://codereview.appspot.com/2012048/

Thank you! Committed in r989327.

I've tweaked the log message a bit, most importanly to mention
the symbol names of things that have changed, which we usually
do in our log messages so that it's easy to find changes made
to a specific struct or function.

Stefan