[GitHub] [pulsar] codelipenghui commented on a change in pull request #11389: Invalidate the read handle after all cursors consumed.

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #11389:
URL: https://github.com/apache/pulsar/pull/11389#discussion_r673206097



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -2410,7 +2410,7 @@ void internalTrimLedgers(boolean isTruncate, CompletableFuture<?> promise) {
                     if (log.isDebugEnabled()) {
                         log.debug("[{}] Ledger {} not deleted. Neither expired nor over-quota", name, ls.getLedgerId());
                     }
-                    break;

Review comment:
       because we need to close the ReadHandle, otherwise, only one ReadHandle will be closed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org