You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2023/01/10 09:17:51 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #18550: [fix][ml] Ensure ManagedLedger readEntryOps can be finished within `readEntryTimeoutSeconds`

tisonkun commented on code in PR #18550:
URL: https://github.com/apache/pulsar/pull/18550#discussion_r1065521005


##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java:
##########
@@ -2988,57 +2991,88 @@ public void testManagedLedgerWithReadEntryTimeOut() throws Exception {
 

Review Comment:
   Does the original test case fail with your change? If not, I suggest you add a new case instead of modifying an existing case. Otherwise, it looks like a breaking change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org